Getting warnings in console on fresh build #18983

prog1dev · 2018-02-25T09:07:50Z

I get various warnings in console output if I build node from scratch with ./configure && make -j4.
I guess its nothing to worry about but it might be good first contributions?
Here there are:

../deps/icu-small/source/common/unistr.cpp:1941:13: warning: unused function 'uprv_UnicodeStringDummy' [-Wunused-function]
static void uprv_UnicodeStringDummy(void) {

../deps/openssl/openssl/ssl/d1_srtp.c:143:7: warning: missing field 'id' initializer [-Wmissing-field-initializers]
    {0}
      ^
1 warning generated.

../deps/openssl/openssl/ssl/ssl_lib.c:188:1: warning: missing field 'enc_flags' initializer [-Wmissing-field-initializers]
};
^

../deps/openssl/openssl/crypto/cmac/cm_ameth.c:96:1: warning: missing field 'item_verify' initializer [-Wmissing-field-initializers]
};
^
1 warning generated.

../deps/openssl/openssl/crypto/dh/dh_ameth.c:617:1: warning: missing field 'old_priv_decode' initializer [-Wmissing-field-initializers]
};
^
../deps/openssl/openssl/crypto/dh/dh_ameth.c:649:1: warning: missing field 'old_priv_decode' initializer [-Wmissing-field-initializers]
};
^

../deps/openssl/openssl/crypto/dsa/dsa_ameth.c:634:21: warning: missing field 'pem_str' initializer [-Wmissing-field-initializers]
     ASN1_PKEY_ALIAS},
                    ^
../deps/openssl/openssl/crypto/dsa/dsa_ameth.c:639:21: warning: missing field 'pem_str' initializer [-Wmissing-field-initializers]
     ASN1_PKEY_ALIAS},
                    ^
../deps/openssl/openssl/crypto/dsa/dsa_ameth.c:644:21: warning: missing field 'pem_str' initializer [-Wmissing-field-initializers]
     ASN1_PKEY_ALIAS},
                    ^
../deps/openssl/openssl/crypto/dsa/dsa_ameth.c:649:21: warning: missing field 'pem_str' initializer [-Wmissing-field-initializers]
     ASN1_PKEY_ALIAS},
                    ^
../deps/openssl/openssl/crypto/dsa/dsa_ameth.c:682:25: warning: missing field 'item_verify' initializer [-Wmissing-field-initializers]
     old_dsa_priv_encode}
                        ^

../deps/openssl/openssl/crypto/ec/ec_ameth.c:644:1: warning: missing field 'item_verify' initializer [-Wmissing-field-initializers]
};
^
1 warning generated.

../deps/openssl/openssl/crypto/engine/eng_openssl.c:361:1: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]
};
^
1 warning generated.

../deps/openssl/openssl/crypto/evp/m_dss.c:98:1: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]
};
^
1 warning generated.

../deps/openssl/openssl/crypto/evp/m_dss1.c:99:1: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]
};
^
1 warning generated.
../deps/openssl/openssl/crypto/evp/m_ecdsa.c:148:1: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]
};
^
1 warning generated.
../deps/openssl/openssl/crypto/evp/m_md4.c:102:1: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]
};
^
1 warning generated.

../deps/openssl/openssl/crypto/evp/m_md5.c:101:1: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]
};
^
../deps/openssl/openssl/crypto/evp/m_mdc2.c:102:1: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]
};
^
../deps/openssl/openssl/crypto/evp/m_null.c:93:1: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]
};
^1 warning generated.

1 warning generated.
1 warning generated.
../deps/openssl/openssl/crypto/evp/m_ripemd.c:101:1: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]
};
^
1 warning generated.

../deps/openssl/openssl/crypto/evp/m_sha1.c:99:1: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]
};
^
../deps/openssl/openssl/crypto/evp/m_sha1.c:146:1: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]
};
^
../deps/openssl/openssl/crypto/evp/m_sha1.c:166:1: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]
};
^
../deps/openssl/openssl/crypto/evp/m_sha1.c:209:1: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]
};
^
../deps/openssl/openssl/crypto/evp/m_sha1.c:229:1: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]
};
^
../deps/openssl/openssl/crypto/evp/m_sha.c:100:1: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]
};
^
../deps/openssl/openssl/crypto/evp/m_wp.c:42:1: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]
};
^
5 warnings generated.
1 warning generated.
1 warning generated.

../deps/openssl/openssl/crypto/hmac/hm_ameth.c:167:1: warning: missing field 'item_verify' initializer [-Wmissing-field-initializers]
};
^
1 warning generated.

../deps/openssl/openssl/crypto/rsa/rsa_ameth.c:966:21: warning: missing field 'pem_str' initializer [-Wmissing-field-initializers]
     ASN1_PKEY_ALIAS}
                    ^
1 warning generated.

../deps/icu-small/source/tools/genrb/read.c:167:23: warning: comparison of integers of different signs: 'UChar32' (aka 'int') and 'unsigned int' [-Wsign-compare]
                if (c == U_EOF) {
                    ~ ^  ~~~~~
../deps/icu-small/source/tools/genrb/read.c:184:27: warning: comparison of integers of different signs: 'UChar32' (aka 'int') and 'unsigned int' [-Wsign-compare]
                    if (c == U_ERR) {
                        ~ ^  ~~~~~
../deps/icu-small/source/tools/genrb/read.c:245:23: warning: comparison of integers of different signs: 'UChar32' (aka 'int') and 'unsigned int' [-Wsign-compare]
                if (c == U_EOF) {
                    ~ ^  ~~~~~
../deps/icu-small/source/tools/genrb/read.c:264:23: warning: comparison of integers of different signs: 'UChar32' (aka 'int') and 'unsigned int' [-Wsign-compare]
                if (c == U_EOF) {
                    ~ ^  ~~~~~
../deps/icu-small/source/tools/genrb/read.c:290:27: warning: comparison of integers of different signs: 'UChar32' (aka 'int') and 'unsigned int' [-Wsign-compare]
                    if (c == U_ERR) {
                        ~ ^  ~~~~~
../deps/icu-small/source/tools/genrb/read.c:334:15: warning: comparison of integers of different signs: 'UChar32' (aka 'int') and 'unsigned int' [-Wsign-compare]
        if (c == U_EOF) {
            ~ ^  ~~~~~
../deps/icu-small/source/tools/genrb/read.c:349:15: warning: comparison of integers of different signs: 'UChar32' (aka 'int') and 'unsigned int' [-Wsign-compare]
        if (c == U_EOF) {
            ~ ^  ~~~~~
../deps/icu-small/source/tools/genrb/read.c:393:33: warning: comparison of integers of different signs: 'UChar32' (aka 'int') and 'unsigned int' [-Wsign-compare]
    } while (!isNewline(c) && c != U_EOF && *status == U_ZERO_ERROR);
                              ~ ^  ~~~~~
../deps/icu-small/source/tools/genrb/read.c:427:16: warning: comparison of integers of different signs: 'UChar32' (aka 'int') and 'unsigned int' [-Wsign-compare]
    } while (c != U_EOF && *status == U_ZERO_ERROR);
             ~ ^  ~~~~~
../deps/icu-small/source/tools/genrb/read.c:429:11: warning: comparison of integers of different signs: 'UChar32' (aka 'int') and 'unsigned int' [-Wsign-compare]
    if (c == U_EOF) {
        ~ ^  ~~~~~

../deps/v8/src/wasm/function-body-decoder.cc:49:23: warning: missing field 'mem_size' initializer [-Wmissing-field-initializers]
    context_cache = {0};
                      ^
../deps/v8/src/wasm/function-body-decoder.cc:752:33: warning: missing field 'mem_size' initializer [-Wmissing-field-initializers]
      result->context_cache = {0};
                                ^
../deps/v8/src/wasm/function-body-decoder.cc:780:31: warning: missing field 'mem_size' initializer [-Wmissing-field-initializers]
    result->context_cache = {0};
                              ^

Version: current master branch
Platform: macOS High Sierra 10.13.3
Subsystem: build

The text was updated successfully, but these errors were encountered:

benjamingr · 2018-02-25T13:23:39Z

Hey, thanks for opening the issue.

All these warnings are in Node.js direct dependencies (V8, icu-small, openssl) and they'd have to be fixed there and not in Node. The Node deps folder contains other projects Node depends on copied.

Maybe document it in the guide?

prog1dev · 2018-02-25T13:36:16Z

You mean in BUILDING.md guide?
And how do you think it should be phrased?

benjamingr · 2018-02-25T13:47:08Z

Maybe as a note below the text "Note that the above requires that python resolve to Python 2.6 or 2.7 and not a newer version."?

We already disable `-Wmissing-field-initializers` on other Unices but not on MacOS. Fixes: nodejs#18983 (partially)

apapirovski · 2018-03-04T12:23:06Z

This is only partially addressed by the commit above. Re-opening.

We already disable `-Wmissing-field-initializers` on other Unices but not on MacOS. PR-URL: nodejs#19046 Fixes: nodejs#18983 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>

We already disable `-Wmissing-field-initializers` on other Unices but not on MacOS. PR-URL: #19046 Fixes: #18983 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>

gireeshpunathil · 2019-12-30T09:53:08Z

fwiw, here is the outstanding set of warnings when I checked the master on a linux x64:

make: Warning: File `tools/v8_gypfiles/v8_version.target.mk' has modification time 3562 s in the future
../deps/icu-small/source/i18n/collationweights.cpp: In member function ‘UBool icu_65::CollationWeights::allocWeights(uint32_t, uint32_t, int32_t)’:
../deps/icu-small/source/i18n/collationweights.cpp:394:39: warning: assuming signed overflow does not occur when assuming that (X + c) < X is always false [-Wstrict-overflow]
     for(int32_t i = 0; i < rangeCount && ranges[i].length <= (minLength + 1); ++i) {
                        ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../deps/icu-small/source/i18n/olsontz.cpp: In member function ‘virtual UBool icu_65::OlsonTimeZone::inDaylightTime(UDate, UErrorCode&) const’:
../deps/icu-small/source/i18n/olsontz.cpp:601:18: warning: ‘dst’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     int32_t raw, dst;
                  ^~~
../deps/icu-small/source/common/unistr.cpp:1975:13: warning: ‘void uprv_UnicodeStringDummy()’ defined but not used [-Wunused-function]
 static void uprv_UnicodeStringDummy(void) {
             ^~~~~~~~~~~~~~~~~~~~~~~
../deps/icu-small/source/common/unistr.cpp:1975:13: warning: ‘void uprv_UnicodeStringDummy()’ defined but not used [-Wunused-function]
 static void uprv_UnicodeStringDummy(void) {
             ^~~~~~~~~~~~~~~~~~~~~~~
../deps/icu-small/source/i18n/collationweights.cpp: In member function ‘UBool icu_65::CollationWeights::allocWeights(uint32_t, uint32_t, int32_t)’:
../deps/icu-small/source/i18n/collationweights.cpp:394:39: warning: assuming signed overflow does not occur when assuming that (X + c) < X is always false [-Wstrict-overflow]
     for(int32_t i = 0; i < rangeCount && ranges[i].length <= (minLength + 1); ++i) {
                        ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../deps/icu-small/source/i18n/olsontz.cpp: In member function ‘virtual UBool icu_65::OlsonTimeZone::inDaylightTime(UDate, UErrorCode&) const’:
../deps/icu-small/source/i18n/olsontz.cpp:601:18: warning: ‘dst’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     int32_t raw, dst;
                  ^~~
../deps/uvwasi/src/uvwasi.c: In function ‘uvwasi_fd_readdir’:
../deps/uvwasi/src/uvwasi.c:1204:5: warning: implicit declaration of function ‘seekdir’ [-Wimplicit-function-declaration]
     seekdir(dir->dir, cookie);
     ^~~~~~~
../deps/uvwasi/src/uvwasi.c:1223:14: warning: implicit declaration of function ‘telldir’ [-Wimplicit-function-declaration]
       tell = telldir(dir->dir);
              ^~~~~~~
../deps/uvwasi/src/uvwasi.c: In function ‘uvwasi_path_readlink’:
../deps/uvwasi/src/uvwasi.c:1840:9: warning: implicit declaration of function ‘strnlen’ [-Wimplicit-function-declaration]
   len = strnlen(req.ptr, buf_len);
         ^~~~~~~
../deps/llhttp/src/llhttp.c:56:38: warning: ‘llparse_blob10’ defined but not used [-Wunused-const-variable=]
 static const unsigned char ALIGN(16) llparse_blob10[] = {
                                      ^~~~~~~~~~~~~~
../deps/llhttp/src/llhttp.c:52:38: warning: ‘llparse_blob9’ defined but not used [-Wunused-const-variable=]
 static const unsigned char ALIGN(16) llparse_blob9[] = {
                                      ^~~~~~~~~~~~~
../deps/llhttp/src/llhttp.c:46:38: warning: ‘llparse_blob7’ defined but not used [-Wunused-const-variable=]
 static const unsigned char ALIGN(16) llparse_blob7[] = {
                                      ^~~~~~~~~~~~~
../deps/llhttp/src/llhttp.c:27:38: warning: ‘llparse_blob1’ defined but not used [-Wunused-const-variable=]
 static const unsigned char ALIGN(16) llparse_blob1[] = {
                                      ^~~~~~~~~~~~~
../deps/uv/src/unix/fs.c: In function ‘uv__fs_mkstemp’:
../deps/uv/src/unix/fs.c:289:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
     *(int**)(&mkostemp_function) = dlsym(RTLD_DEFAULT, "mkostemp");
     ^
../src/node_env_var.cc: In copy constructor ‘node::MapKVStore::MapKVStore(const node::MapKVStore&)’:
../src/node_env_var.cc:50:3: warning: base class ‘class node::KVStore’ should be explicitly initialized in the copy constructor [-Wextra]
   MapKVStore(const MapKVStore& other) : map_(other.map_) {}
   ^~~~~~~~~~

HarshithaKP · 2019-12-30T11:19:49Z

I would like to work on few of these.

Initialise the superclass object in the copy constructor of mapKVStore PR-URL: #31136 Refs: #18983 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Mesteery · 2022-02-17T22:13:41Z

I guess it's fixed? Feel free to (or ask to) reopen if it isn't.

ChALkeR added the build Issues and PRs related to build files or the CI. label Feb 25, 2018

bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Feb 27, 2018

build: disable openssl build warnings on macos

178ece8

We already disable `-Wmissing-field-initializers` on other Unices but not on MacOS. Fixes: nodejs#18983 (partially)

bnoordhuis mentioned this issue Feb 27, 2018

build: disable openssl build warnings on macos #19046

Closed

apapirovski closed this as completed in cb94bf0 Mar 4, 2018

apapirovski reopened this Mar 4, 2018

This was referenced Dec 30, 2019

src: suppress warning in src/node_env_var.cc #31136

Closed

deps: suppress warnings in deps/uvwasi/src/uvwasi.c #31139

Closed

gireeshpunathil mentioned this issue Jan 7, 2020

GCC warnings when compiling files in src #26733

Closed

62f mentioned this issue Sep 13, 2020

unistr.cpp:1979:13: warning: 'void uprv_UnicodeStringDummy()' defined but not used [-Wunused-function] #35176

Closed

Mesteery closed this as completed Feb 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Getting warnings in console on fresh build #18983

Getting warnings in console on fresh build #18983

prog1dev commented Feb 25, 2018 •

edited

Loading

benjamingr commented Feb 25, 2018

prog1dev commented Feb 25, 2018 •

edited

Loading

benjamingr commented Feb 25, 2018

apapirovski commented Mar 4, 2018 •

edited

Loading

gireeshpunathil commented Dec 30, 2019

HarshithaKP commented Dec 30, 2019

Mesteery commented Feb 17, 2022

Getting warnings in console on fresh build #18983

Getting warnings in console on fresh build #18983

Comments

prog1dev commented Feb 25, 2018 • edited Loading

benjamingr commented Feb 25, 2018

prog1dev commented Feb 25, 2018 • edited Loading

benjamingr commented Feb 25, 2018

apapirovski commented Mar 4, 2018 • edited Loading

gireeshpunathil commented Dec 30, 2019

HarshithaKP commented Dec 30, 2019

Mesteery commented Feb 17, 2022

prog1dev commented Feb 25, 2018 •

edited

Loading

prog1dev commented Feb 25, 2018 •

edited

Loading

apapirovski commented Mar 4, 2018 •

edited

Loading