Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OutgoingMessage should set writable false #33643

Open
ronag opened this issue May 29, 2020 · 2 comments
Open

OutgoingMessage should set writable false #33643

ronag opened this issue May 29, 2020 · 2 comments
Labels
http Issues or PRs related to the http subsystem. stream Issues and PRs related to the stream subsystem.

Comments

@ronag
Copy link
Member

ronag commented May 29, 2020

In #33131 we aligned OutgoingMessage to properly set the destroyed property. We should do the same for writable in order to properly align with streams.
@ronag ronag added http Issues or PRs related to the http subsystem. stream Issues and PRs related to the stream subsystem. good first issue Issues that are suitable for first-time contributors. labels May 29, 2020
@ronag ronag mentioned this issue May 29, 2020
Closed
@ronag ronag mentioned this issue May 30, 2020
Closed
4 tasks
ronag added a commit to nxtedition/node that referenced this issue Jun 14, 2020
@ronag
http: align OutgoingMessage.writable with streams
7cbc07f 
Should be a computed value that looks at finished and
destroyed state.

Fixes: nodejs#33643
@qballer
Copy link

qballer commented Jul 24, 2020

Hey, I would like to work on the PR as the first contribution to Node. Will be working on this tonight

@mcollina
Copy link
Member

@qballer I'm sorry but there seems to be a PR already open for this :(.

@targos targos removed the good first issue Issues that are suitable for first-time contributors. label Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

http: align OutgoingMessage.writable with streams nxtedition/node
4 participants
@mcollina @qballer @targos @ronag