Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-http-destroyed-socket-write2 timeout #36081

Closed
rickyes opened this issue Nov 11, 2020 · 0 comments · Fixed by #36120
Closed

test-http-destroyed-socket-write2 timeout #36081

rickyes opened this issue Nov 11, 2020 · 0 comments · Fixed by #36120
Assignees
@rickyes
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem.

Comments

@rickyes
Copy link
Contributor

rickyes commented Nov 11, 2020

  • Test: test-http-destroyed-socket-write2
  • Platform: OSX
  • Console Output:
 not ok 1781 parallel/test-http-destroyed-socket-write2
   ---
   duration_ms: 120.48
   severity: fail
   exitcode: -15
   stack: |-
     timeout
@rickyes rickyes added http Issues or PRs related to the http subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Nov 11, 2020
@rickyes rickyes self-assigned this Nov 12, 2020
@lpinca lpinca mentioned this issue Nov 14, 2020
Merged
3 tasks
@lpinca lpinca closed this as completed in e682814 Nov 18, 2020
codebytere pushed a commit that referenced this issue Nov 22, 2020
@lpinca @codebytere
test: deflake test-http-destroyed-socket-write2
4746649 
Ensure that the write occurs in the same tick where the socket is
destroyed by the other peer.

PR-URL: #36120
Fixes: #36081
Fixes: #4066
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
BethGriggs pushed a commit that referenced this issue Dec 10, 2020
@lpinca @BethGriggs
test: deflake test-http-destroyed-socket-write2
fa14657 
Ensure that the write occurs in the same tick where the socket is
destroyed by the other peer.

PR-URL: #36120
Fixes: #36081
Fixes: #4066
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
BethGriggs pushed a commit that referenced this issue Dec 10, 2020
@lpinca @BethGriggs
test: deflake test-http-destroyed-socket-write2
ed1a114 
Ensure that the write occurs in the same tick where the socket is
destroyed by the other peer.

PR-URL: #36120
Fixes: #36081
Fixes: #4066
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
BethGriggs pushed a commit that referenced this issue Dec 15, 2020
@lpinca @BethGriggs
test: deflake test-http-destroyed-socket-write2
3e77536 
Ensure that the write occurs in the same tick where the socket is
destroyed by the other peer.

PR-URL: #36120
Fixes: #36081
Fixes: #4066
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rickyes rickyes

Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: deflake test-http-destroyed-socket-write2 lpinca/node
1 participant
@rickyes