Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 'data' argument on callback of Transform._flush() #3707

Closed
piranna opened this issue Nov 7, 2015 · 3 comments
Closed

Allow 'data' argument on callback of Transform._flush() #3707

piranna opened this issue Nov 7, 2015 · 3 comments
Labels
feature request Issues that request new features to be added to Node.js. stream Issues and PRs related to the stream subsystem.

Comments

@piranna
Copy link
Contributor

piranna commented Nov 7, 2015

According to the docs, transform._transform(chunk, encoding, callback) callback accept optionals error and data chunk:

If you supply a second argument to the callback it will be passed to the push method

but the callback of transform._flush(callback) only accept an optional error. According to the code it would be fairly easy to add.

@piranna
Copy link
Contributor Author

piranna commented Nov 7, 2015

I've done a pull-request for this.

@mscdex mscdex added the stream Issues and PRs related to the stream subsystem. label Nov 8, 2015
@brendanashworth brendanashworth added the feature request Issues that request new features to be added to Node.js. label Nov 8, 2015
@piranna
Copy link
Contributor Author

piranna commented May 25, 2016

Any update on this?

piranna added a commit to piranna/node that referenced this issue Jun 7, 2016
Add a `data` argument on Transform._flush() callback to be API consistent with Transform._transform().

Fixes: nodejs#3707
@piranna
Copy link
Contributor Author

piranna commented Jun 9, 2016

Thank you :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issues that request new features to be added to Node.js. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

No branches or pull requests

3 participants