Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: parallel/test-https-agent-unref-socket requires external network connection #39008

Closed
AdamMajer opened this issue Jun 11, 2021 · 1 comment

Comments

@AdamMajer
Copy link
Contributor

  • Version: 16.3.0
  • Platform:
  • Subsystem: test

What steps will reproduce the bug?

Commit 4e33532 introduced a network fragile test which fails when there is no network available,

[ 1771s] not ok 1637 parallel/test-https-agent-unref-socket
[ 1771s]   ---
[ 1771s]   duration_ms: 1.399
[ 1771s]   severity: fail
[ 1771s]   exitcode: 1
[ 1771s]   stack: |-
[ 1771s]     node:events:371
[ 1771s]           throw er; // Unhandled 'error' event
[ 1771s]           ^
[ 1771s]     
[ 1771s]     Error: getaddrinfo EAI_AGAIN example.com
[ 1771s]         at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:69:26)
[ 1771s]     Emitted 'error' event on ClientRequest instance at:
[ 1771s]         at TLSSocket.socketErrorListener (node:_http_client:447:9)
[ 1771s]         at TLSSocket.emit (node:events:394:28)
[ 1771s]         at emitErrorNT (node:internal/streams/destroy:193:8)
[ 1771s]         at emitErrorCloseNT (node:internal/streams/destroy:158:3)
[ 1771s]         at processTicksAndRejections (node:internal/process/task_queues:83:21) {
[ 1771s]       errno: -3001,
[ 1771s]       code: 'EAI_AGAIN',
[ 1771s]       syscall: 'getaddrinfo',
[ 1771s]       hostname: 'example.com'
[ 1771s]     }
[ 1771s]   ...
AdamMajer added a commit to AdamMajer/node that referenced this issue Jun 11, 2021
AdamMajer added a commit to AdamMajer/node that referenced this issue Jun 14, 2021
targos pushed a commit that referenced this issue Jul 11, 2021
Fixes: #39008

PR-URL: #39011
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@batrla
Copy link
Contributor

batrla commented Aug 2, 2021

This fix is missing on Node.js 14 branch, causing test failure if running make test on system w/o internet connection:

out/Release/node /some/path/nodejs14/build/amd64/te
st/parallel/test-https-agent-unref-socket.js
events.js:377
      throw er; // Unhandled 'error' event
      ^

Error: connect EHOSTUNREACH 93.184.216.34:443
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1148:16)
Emitted 'error' event on ClientRequest instance at:
    at TLSSocket.socketErrorListener (_http_client.js:475:9)
    at TLSSocket.emit (events.js:400:28)
    at emitErrorNT (internal/streams/destroy.js:106:8)
    at emitErrorCloseNT (internal/streams/destroy.js:74:3)
    at processTicksAndRejections (internal/process/task_queues.js:82:21) {
  errno: -148,
  code: 'EHOSTUNREACH',
  syscall: 'connect',
  address: '93.184.216.34',
  port: 443
}

How do I request backporting the fix to 14.x branch?

targos pushed a commit that referenced this issue Sep 4, 2021
Fixes: #39008

PR-URL: #39011
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants