Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request to backport "fix memory leak when nghttp2 hd threshold is reached" into v14.x #45295

Closed
ywave620 opened this issue Nov 3, 2022 · 2 comments
Closed

Request to backport "fix memory leak when nghttp2 hd threshold is reached" into v14.x #45295

ywave620 opened this issue Nov 3, 2022 · 2 comments

Comments

@ywave620
Copy link
Contributor

ywave620 commented Nov 3, 2022

Version

14x

Platform

linux,mac,window

Subsystem

http2

What steps will reproduce the bug?

As shown in #35233
Fix in #41502

How often does it reproduce? Is there a required condition?

Consistent reproducable

What is the expected behavior?

no crash

What do you see instead?

./src/node_http2.cc:522:virtual node::http2::Http2Session::~Http2Session(): Assertion `(current_nghttp2_memory_) == (0)' failed.
1: 0xa02dd0 node::Abort() [node]

Additional information

I can't find the fix commit(f98a785) in https://github.com/nodejs/node/blob/v14.x/doc/changelogs/CHANGELOG_V14.md, since this is a critial bug that will lead to crash and v14.x is a LTS, I request Node team to backport it.
@aduh95
Copy link
Contributor

aduh95 commented Nov 3, 2022

v14.x is in maintenance mode, meaning no commit will land on it without a manual backport. Your best shot to see it being backported is to open a backport PR youself as documented in https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md.

ywave620 added a commit to ywave620/node that referenced this issue Nov 4, 2022
@ywave620
http2: fix memory leak when nghttp2 hd threshold is reached
df2b6b3 
Refs: nodejs#45295
@ywave620 ywave620 mentioned this issue Nov 4, 2022
Closed
richardlau pushed a commit that referenced this issue Nov 23, 2022
@ywave620 @richardlau
http2: fix memory leak when nghttp2 hd threshold is reached
c3a90c4 
Refs: #45295
PR-URL: #41502
Backport-PR-URL: #45310
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@ywave620
Copy link
Contributor Author

landed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aduh95 @ywave620