test_runner: incorrect test:pass & test:fail events description, 'duration' instead of 'duration_ms'

[koshic]

Affected URL(s)

https://nodejs.org/dist/latest/docs/api/test.html

Description of the problem

Docs:

Reality:

node/lib/internal/test_runner/test.js

Lines 712 to 720 in 6c08b1f

	report() {
	countCompletedTest(this);
	if (this.subtests.length > 0) {
	this.reporter.plan(this.subtests[0].nesting, kFilename, this.subtests.length);
	} else {
	this.reportStarted();
	}
	let directive;
	const details = { __proto__: null, duration_ms: this.#duration() };

@types/node also contains wrong object shape.

[heysujal]

@MoLow I am new to this project and would like to work on this issue.

[MoLow]

The best thing to do is to open a PR fixing the documentation

[ardinugrxha]

hi @MoLow I want to take this, I have a question for more clarity on this, the expected result is whether should we use 'duration' or 'duration_ms' for the test cases on [node/lib/internal/test_runner/test.js] ?

[MoLow]

the code emits duration_ms, but documentation mentions duration

[ardinugrxha]

hi, i'am already working on that. please help to review :) thank you

[heysujal]

@0xArdi-N nice work. just a friendly reminder that you should wait for other people who have already been working on this issue before you make a PR.

[ardinugrxha]

@heysujal thank you sujal :)