Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaky: test-child-process-cwd #53989

Closed
EarlyRiser42 opened this issue Jul 22, 2024 · 0 comments · Fixed by #53993
Closed

flaky: test-child-process-cwd #53989

EarlyRiser42 opened this issue Jul 22, 2024 · 0 comments · Fixed by #53993
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform.

Comments

@EarlyRiser42
Copy link
Contributor

Test

test-child-process-cwd

Platform

Windows

Console output

node:assert:126
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected

+ 'C:\\Windows'
- 'C:\\WINDOWS'
        ^
    at ChildProcess.<anonymous> (C:\Users\admin\WebstormProjects\node\test\parallel\test-child-process-cwd.js:55:26)
    at ChildProcess.<anonymous> (C:\Users\admin\WebstormProjects\node\test\common\index.js:487:15)
    at ChildProcess.emit (node:events:520:28)
    at maybeClose (node:internal/child_process:1105:16)
    at Socket.<anonymous> (node:internal/child_process:457:11)
    at Socket.emit (node:events:520:28)
    at Pipe.<anonymous> (node:net:337:12) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 'C:\\Windows',
  expected: 'C:\\WINDOWS',
  operator: 'strictEqual'
}

Node.js v23.0.0-pre

Build links

Additional information

Issue Description

I built Node.js on my local computer using the vcbuild.bat script. After the build was completed, I verified it through the Release\node directory. However, when running .\vcbuild test, I consistently encountered the same error. The error seems to be caused by Windows not distinguishing between uppercase and lowercase folder names.

@EarlyRiser42 EarlyRiser42 added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Jul 22, 2024
@github-actions github-actions bot added the windows Issues and PRs related to the Windows platform. label Jul 22, 2024
EarlyRiser42 added a commit to EarlyRiser42/node that referenced this issue Jul 22, 2024
lpinca added a commit to lpinca/node that referenced this issue Jul 22, 2024
targos pushed a commit that referenced this issue Jul 28, 2024
PR-URL: #53993
Fixes: #53989
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this issue Aug 5, 2024
PR-URL: #53993
Fixes: #53989
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito pushed a commit that referenced this issue Aug 19, 2024
PR-URL: #53993
Fixes: #53989
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito pushed a commit that referenced this issue Aug 19, 2024
PR-URL: #53993
Fixes: #53989
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito pushed a commit that referenced this issue Aug 19, 2024
PR-URL: #53993
Fixes: #53989
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
1 participant