Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate (flaky?) test-http-set-timeout-server on SmartOS #6197

Closed
Trott opened this issue Apr 14, 2016 · 1 comment
Closed

Investigate (flaky?) test-http-set-timeout-server on SmartOS #6197

Trott opened this issue Apr 14, 2016 · 1 comment
Labels
http Issues or PRs related to the http subsystem. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Apr 14, 2016

Example failure: https://ci.nodejs.org/job/node-test-commit-smartos/2074/nodes=smartos14-32/tapTestReport/test.tap-491/

not ok 491 test-http-set-timeout-server.js
# events.js:154
#       throw er; // Unhandled 'error' event
#       ^
# 
# Error: listen EADDRINUSE :::12346
#     at Object.exports._errnoException (util.js:893:11)
#     at exports._exceptionWithHostPort (util.js:916:20)
#     at Server._listen2 (net.js:1225:14)
#     at listen (net.js:1261:10)
#     at Server.listen (net.js:1358:5)
#     at serverResponseTimeoutWithPipeline (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-32/test/parallel/test-http-set-timeout-server.js:128:10)
#     at run (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-32/test/parallel/test-http-set-timeout-server.js:19:5)
#     at Server.<anonymous> (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-32/test/parallel/test-http-set-timeout-server.js:105:5)
#     at emitOne (events.js:90:13)
#     at Server.emit (events.js:182:7)
# # serverTimeout
# # serverRequestTimeout
# # serverResponseTimeout
# # serverRequestNotTimeoutAfterEnd
# # serverResponseTimeoutWithPipeline
  ---
  duration_ms: 0.722

/cc @nodejs/testing
@Trott Trott added http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. smartos Issues and PRs related to the SmartOS platform. labels Apr 14, 2016
@santigimeno santigimeno mentioned this issue Apr 16, 2016
Closed
2 tasks
@santigimeno
Copy link
Member

Proposed fix in: #6248

santigimeno added a commit to santigimeno/node that referenced this issue Apr 19, 2016
@santigimeno
test: fix flaky test-http-set-timeout-server
d639bf6 
Make the servers listen on a free port number picked by the OS to avoid
rare `EADDRINUSE` errors on `SmartOS`.

Fixes: nodejs#6197
PR-URL: nodejs#6248
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Apr 19, 2016
@santigimeno
test: fix flaky test-http-set-timeout-server
e4d145a 
Make the servers listen on a free port number picked by the OS to avoid
rare `EADDRINUSE` errors on `SmartOS`.

Fixes: #6197
PR-URL: #6248
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Apr 20, 2016
@santigimeno
test: fix flaky test-http-set-timeout-server
20255bf 
Make the servers listen on a free port number picked by the OS to avoid
rare `EADDRINUSE` errors on `SmartOS`.

Fixes: #6197
PR-URL: #6248
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott pushed a commit to Trott/io.js that referenced this issue Apr 20, 2016
@santigimeno @Trott
test: fix flaky test-http-set-timeout-server
94e1da9 
Make the servers listen on a free port number picked by the OS to avoid
rare `EADDRINUSE` errors on `SmartOS`.

Fixes: nodejs#6197
PR-URL: nodejs#6248
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Apr 20, 2016
@santigimeno
test: fix flaky test-http-set-timeout-server
4be2e15 
Make the servers listen on a free port number picked by the OS to avoid
rare `EADDRINUSE` errors on `SmartOS`.

Fixes: #6197
PR-URL: #6248
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Apr 20, 2016
@santigimeno
test: fix flaky test-http-set-timeout-server
056a258 
Make the servers listen on a free port number picked by the OS to avoid
rare `EADDRINUSE` errors on `SmartOS`.

Fixes: #6197
PR-URL: #6248
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Apr 21, 2016
@santigimeno @MylesBorins
test: fix flaky test-http-set-timeout-server
1af0e44 
Make the servers listen on a free port number picked by the OS to avoid
rare `EADDRINUSE` errors on `SmartOS`.

Fixes: #6197
PR-URL: #6248
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
joelostrowski pushed a commit to joelostrowski/node that referenced this issue Apr 25, 2016
@santigimeno @joelostrowski
test: fix flaky test-http-set-timeout-server
564dbef 
Make the servers listen on a free port number picked by the OS to avoid
rare `EADDRINUSE` errors on `SmartOS`.

Fixes: nodejs#6197
PR-URL: nodejs#6248
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this issue Apr 26, 2016
@santigimeno @jasnell
test: fix flaky test-http-set-timeout-server
4dcb1a2 
Make the servers listen on a free port number picked by the OS to avoid
rare `EADDRINUSE` errors on `SmartOS`.

Fixes: #6197
PR-URL: #6248
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue May 17, 2016
@santigimeno
test: fix flaky test-http-set-timeout-server
738859a 
Make the servers listen on a free port number picked by the OS to avoid
rare `EADDRINUSE` errors on `SmartOS`.

Fixes: #6197
PR-URL: #6248
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue May 18, 2016
@santigimeno
test: fix flaky test-http-set-timeout-server
24ac16f 
Make the servers listen on a free port number picked by the OS to avoid
rare `EADDRINUSE` errors on `SmartOS`.

Fixes: #6197
PR-URL: #6248
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky test-http-set-timeout-server santigimeno/node
2 participants
@Trott @santigimeno