repl: tab completion regression in v6 #6325
Labels
repl
Issues and PRs related to the REPL subsystem.
Comments
|
That seems to be my #6192, sorry… I’m on it. |
3 tasks
3 tasks
addaleax
added a commit
to addaleax/node
that referenced
this issue
Apr 25, 2016
Instead of changing the way “simple” expressions are detected, switch to ignoring errors when completing. This approach is more generic than the previous one from 0b66b8f, but also changes the way errors are thrown when completing. This reverts the code changes from commit 0b66b8f. The test case is left intact. Fixes: nodejs#6325 PR-URL: nodejs#6328 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
pushed a commit
that referenced
this issue
Apr 26, 2016
Instead of changing the way “simple” expressions are detected, switch to ignoring errors when completing. This approach is more generic than the previous one from 0b66b8f, but also changes the way errors are thrown when completing. This reverts the code changes from commit 0b66b8f. The test case is left intact. Fixes: #6325 PR-URL: #6328 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems that tab completion only works if the element to be completed is at the beginning of the line.
Examples:
> buf<TAB>completes tobuffer> <SPACE>buf<TAB>does not complete> buffer.<TAB>completes to the list of buffer properties> var buf = buffer.Slow<TAB>does not completeThe text was updated successfully, but these errors were encountered: