Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zlib: there are constants documented that don't exist #7204

Closed
jasnell opened this issue Jun 7, 2016 · 4 comments
Closed

zlib: there are constants documented that don't exist #7204

jasnell opened this issue Jun 7, 2016 · 4 comments
Labels
doc Issues and PRs related to the documentations. zlib Issues and PRs related to the zlib subsystem.

Comments

@jasnell
Copy link
Member

jasnell commented Jun 7, 2016

In the zlib docs, there are a handful of constants listed that do not exist in the actual code:

Specifically:

  • zlib.Z_BINARY
  • zlib.Z_TEXT
  • zlib.Z_ASCII
  • zlib.Z_UNKNOWN

See: https://nodejs.org/dist/latest-v6.x/docs/api/zlib.html#zlib_constants

Removed in: #7203
@jasnell jasnell added doc Issues and PRs related to the documentations. zlib Issues and PRs related to the zlib subsystem. labels Jun 7, 2016
@Fishrock123 Fishrock123 added the good first issue Issues that are suitable for first-time contributors. label Jun 27, 2016
@tarungarg546
Copy link
Contributor

We would just need to remove these from docs right?

@fhinkel
Copy link
Member

fhinkel commented Jul 2, 2016

It seems like the .md file is already up-to-date. Are the HTML files not updated automatically?

@Fishrock123
Copy link
Contributor

Ah that sounds right. The constants refactor commits have not yet made it into a release.

However, those commits are marked as semver-major (via a label) and will not land in v6: #7203, but the "head: docs come from v6 currently.

@fhinkel Could you check the v6.x branch, and if they are still there but not in the code, open a PR against that branch? :D

@fhinkel fhinkel mentioned this issue Jul 2, 2016
Closed
3 tasks
fhinkel added a commit to fhinkel/node that referenced this issue Jul 9, 2016
@fhinkel
doc: delete non-existing zlib constants
2aabfe6 
Some constants in the zlib docs are not in the actual code:

zlib.Z_BINARY
zlib.Z_TEXT
zlib.Z_ASCII
zlib.Z_UNKNOWN

Also handled in nodejs#7203, but marked as
semver-major, so will not land in v6.x.

Fixes: nodejs#7204
@addaleax addaleax removed the good first issue Issues that are suitable for first-time contributors. label Jul 10, 2016
Fishrock123 pushed a commit that referenced this issue Jul 15, 2016
@fhinkel @Fishrock123
doc: delete non-existing zlib constants
e13ee29 
Some constants in the zlib docs are not in the actual code:

zlib.Z_BINARY
zlib.Z_TEXT
zlib.Z_ASCII
zlib.Z_UNKNOWN

Also handled in #7203, but marked as
semver-major, so will not land in v6.x.

Fixes: #7204
PR-URL: #7520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123
Copy link
Contributor

Fixed in e13ee29

MylesBorins pushed a commit that referenced this issue Sep 9, 2016
@fhinkel
doc: delete non-existing zlib constants
34efb77 
Some constants in the zlib docs are not in the actual code:

zlib.Z_BINARY
zlib.Z_TEXT
zlib.Z_ASCII
zlib.Z_UNKNOWN

Also handled in #7203, but marked as
semver-major, so will not land in v6.x.

Fixes: #7204
PR-URL: #7520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this issue Sep 28, 2016
@fhinkel
doc: delete non-existing zlib constants
fea4a1c 
Some constants in the zlib docs are not in the actual code:

zlib.Z_BINARY
zlib.Z_TEXT
zlib.Z_ASCII
zlib.Z_UNKNOWN

Also handled in #7203, but marked as
semver-major, so will not land in v6.x.

Fixes: #7204
PR-URL: #7520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
rvagg pushed a commit that referenced this issue Oct 18, 2016
@fhinkel @rvagg
doc: delete non-existing zlib constants
6d029fe 
Some constants in the zlib docs are not in the actual code:

zlib.Z_BINARY
zlib.Z_TEXT
zlib.Z_ASCII
zlib.Z_UNKNOWN

Also handled in #7203, but marked as
semver-major, so will not land in v6.x.

Fixes: #7204
PR-URL: #7520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this issue Oct 26, 2016
@fhinkel @MylesBorins
doc: delete non-existing zlib constants
8fec02f 
Some constants in the zlib docs are not in the actual code:

zlib.Z_BINARY
zlib.Z_TEXT
zlib.Z_ASCII
zlib.Z_UNKNOWN

Also handled in #7203, but marked as
semver-major, so will not land in v6.x.

Fixes: #7204
PR-URL: #7520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fhinkel @jasnell @addaleax @Fishrock123 @tarungarg546