Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V8: v8tests.mjsunit/regress/regress-crbug-514081 failure on PPC BE #8750

Closed
mhdawson opened this issue Sep 23, 2016 · 8 comments
Closed

V8: v8tests.mjsunit/regress/regress-crbug-514081 failure on PPC BE #8750

mhdawson opened this issue Sep 23, 2016 · 8 comments
Labels
test Issues and PRs related to the tests. v8 engine Issues and PRs related to the V8 dependency.

Comments

@mhdawson
Copy link
Member

  • Version: master
  • Platform: PPC BE
  • Subsystem: V8

Failure in latest nightly run:

https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=ppcbe-ubuntu1404,v8test=v8test/330/

=== mjsunit/regress/regress-crbug-514081 ===
Command: /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcbe-ubuntu1404/v8test/v8test/deps/v8/out/ppc64.release/d8 --test --random-seed=-1860260574 --nohard-abort --nodead-code-elimination --nofold-constants /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcbe-ubuntu1404/v8test/v8test/deps/v8/test/mjsunit/mjsunit.js /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcbe-ubuntu1404/v8test/v8test/deps/v8/test/mjsunit/regress/regress-crbug-514081.js
exit code: -9
--- CRASHED ---

===
=== 1 tests failed
=== 1 tests CRASHED
@mhdawson
Copy link
Member Author

mhdawson commented Sep 23, 2016 •
edited
Loading

Re-run to see if it is intermittent or persistent https://ci.nodejs.org/job/node-test-commit-v8-linux/334/

Seem to be having timeout problems doing checkouts, will have to wait until nightly runs to get data point on intermittent or consistent.

@mhdawson
Copy link
Member Author

FYI @jbajwa

@mhdawson mhdawson added the v8 engine Issues and PRs related to the V8 dependency. label Sep 23, 2016
@mscdex mscdex added the test Issues and PRs related to the tests. label Sep 23, 2016
@mhdawson
Copy link
Member Author

Latest v8 CI run was green, so failure must be intermittent.

https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=ppcbe-ubuntu1404,v8test=v8test/338/

@jbajwa
Copy link
Contributor

jbajwa commented Sep 27, 2016

yes, seems to be intermittent, I cannot reproduce the failure.

@bnoordhuis
Copy link
Member

The test probably got terminated by the kernel's OOM killer. It tries to create a 2 GB ArrayBuffer and exit code -9 means it was terminated by a SIGKILL signal, which is the signal the OOM killer sends.

Didn't we have a similar issue a few months back?

@mhdawson
Copy link
Member Author

mhdawson commented Oct 3, 2016

Yes found this #6678

@mhdawson
Copy link
Member Author

mhdawson commented Oct 3, 2016

Looks like that floating patch got dropped along the way somewhere

@mhdawson
Copy link
Member Author

mhdawson commented Oct 3, 2016

Putting together PR to re-float patch

v8 CI test run here: https://ci.nodejs.org/job/node-test-commit-v8-linux/347/

@mhdawson mhdawson mentioned this issue Oct 3, 2016
Closed
2 tasks
jasnell pushed a commit that referenced this issue Oct 6, 2016
@mhdawson @jasnell
deps: cherry-pick missing v8 floating patch
c0a3ac2 
2d524bc

Original commit message:

  deps: limit regress/regress-crbug-514081 v8 test

  regress/regress-crbug-514081 allocates a 2G block of memory
  and if there  are multiple variants running at the
  same time this can lead to crashes, OOM kills or
  the OS failing to allocate memory.  This patch
  limits us to running a single variant of the test

  Fixes: #6340
  PR-URL: #6678
  Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  Reviewed-By: James M Snell <jasnell@gmail.com>
  Reviewed-By: Fedor Indutny <fedor@indutny.com>

PR-URL: #8907
Fixes: #8750
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@marijantic marijantic mentioned this issue Nov 21, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mscdex @bnoordhuis @jbajwa @mhdawson