Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: Eliminate ClientRequest capture by Agent socket listeners #10134

Closed
wants to merge 4 commits into from
Closed

http: Eliminate ClientRequest capture by Agent socket listeners #10134

wants to merge 4 commits into from

Commits on Dec 9, 2016

  1. Eliminate capture of "cb" in createSocket context 

    Move the onFree/onClose/onRemote listeners to a separate function
    @evantorrie
    evantorrie committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    3967101 View commit details
    Browse the repository at this point in the history

  2. change to local function instead of prototype

    @evantorrie
    evantorrie committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    f774e72 View commit details
    Browse the repository at this point in the history

  3. change self to agent

    @evantorrie
    evantorrie committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    eb5b0d3 View commit details
    Browse the repository at this point in the history

  4. http: eliminate capture of ClientRequest in Agent 

    Keepalive sockets that are returned to the agent's freesocket pool were
previously capturing a reference to the ClientRequest that initiated the
request.

This commit eliminates that by moving the installation of the socket
listeners to a different function.
    @evantorrie
    evantorrie committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    518d33d View commit details
    Browse the repository at this point in the history