test: add test cases to test-readline-keys.js #10772
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
test
mscdex
added
readline
|
@Trott Would you be able to confirm this PR? |
|
@nodejs/testing Anyone want to take a look at this one? This looks to me like it changes existing test cases (but not behavior) rather than merely adding new test cases. Are we OK with that? |
|
Looks like this just appends new keys to the same test case instead of putting them in a following one. I think it's probably safe. |
3 tasks
hiroppy
force-pushed
the
feature/add-readline-keys-test
branch
from
b3fcc5e
to
a5d702a
Compare
jasnell
approved these changes
Feb 3, 2017
joyeecheung
approved these changes
Feb 8, 2017
jasnell
pushed a commit
that referenced
this pull request
Feb 8, 2017
PR-URL: #10772 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
|
Landed in 2db3b94 |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 9, 2017
PR-URL: nodejs#10772 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
PR-URL: nodejs#10772 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
PR-URL: nodejs#10772 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
|
would need backport PRs to land in v6 or v4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test cases for all patterns of readline.js.
Make use of arrow function.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test