Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: don't imply that we still do io.js releases #11054

Merged
merged 1 commit into from
Feb 11, 2017
Merged

doc: don't imply that we still do io.js releases #11054

merged 1 commit into from
Feb 11, 2017

Conversation

bnoordhuis
Copy link
Member

Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

cc @ChALkeR

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. lts-watch-v6.x labels Jan 28, 2017
@bnoordhuis bnoordhuis mentioned this pull request Jan 28, 2017
Merged
Fishrock123
Fishrock123 previously requested changes Jan 28, 2017
View reviewed changes
README.md Outdated
Previous releases of Node.js have been signed with one of the following GPG
keys:
Previous releases of Node.js and io.js have been signed with one of the
following GPG keys:
Copy link
Contributor

@Fishrock123 Fishrock123 Jan 28, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this isn't correct. Most of the current keys were the ones used for signing io.js releases.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps with either one of those or one of the following GPG keys? I'm not sure that's the best way to say it, though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or how about

-Releases of Node.js and io.js will be signed with one of the following GPG keys:
+Releases of Node.js will be signed with one of the following GPG keys, so have
+previous releases of io.js:

Not the most grammatically correct per se, but it is the most concise I can think of.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about I drop the reference to io.js altogether?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe put a line above this one that says: io.js releases may have been signed with any of the keys above or below.

I think hat may be the closest while still easy enough to understand.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't support any of the io.js releases anymore anyway. So +1 on just saying Node.js and leaving it at that.

@bnoordhuis bnoordhuis force-pushed the update-readme-release-language branch from eb519fd to e8e3d7b Compare February 7, 2017 15:26
@bnoordhuis
Copy link
Member Author

Reworded, PTAL.

ChALkeR
ChALkeR approved these changes Feb 8, 2017
View reviewed changes
Copy link
Member

@ChALkeR ChALkeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM =).

@bnoordhuis
Copy link
Member Author

@Fishrock123 LGTY?

@bnoordhuis
doc: drop "and io.js" from release section
1062736 
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: nodejs#11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@bnoordhuis bnoordhuis closed this Feb 11, 2017
@bnoordhuis bnoordhuis deleted the update-readme-release-language branch February 11, 2017 14:54
@bnoordhuis bnoordhuis merged commit 1062736 into nodejs:master Feb 11, 2017
italoacasas pushed a commit that referenced this pull request Feb 13, 2017
@bnoordhuis @italoacasas
doc: drop "and io.js" from release section
a479746 
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: #11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 13, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
@bnoordhuis @italoacasas
doc: drop "and io.js" from release section
1b08f76 
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: nodejs#11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
@bnoordhuis @krydos
doc: drop "and io.js" from release section
4822815 
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: nodejs#11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@bnoordhuis @jasnell
doc: drop "and io.js" from release section
5f041d1 
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: #11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@bnoordhuis @jasnell
doc: drop "and io.js" from release section
a81fbbd 
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: #11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@bnoordhuis @MylesBorins
doc: drop "and io.js" from release section
ade39cd 
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: #11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@bnoordhuis @MylesBorins
doc: drop "and io.js" from release section
10afa8b 
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: #11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@Fishrock123 Fishrock123 Fishrock123 left review comments

@TimothyGu TimothyGu TimothyGu left review comments

@ChALkeR ChALkeR ChALkeR approved these changes

@danbev danbev danbev approved these changes

@jasnell jasnell jasnell approved these changes

@evanlucas evanlucas evanlucas approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.