Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: ensure --check flag works for piped-in code #11689

Closed
wants to merge 7 commits into from
Closed

cli: ensure --check flag works for piped-in code #11689

wants to merge 7 commits into from

Commits on Apr 1, 2017

  1. cli: ensure --check flag works for piped-in code 

    Previously, the --check CLI flag had no effect when run on code piped
from stdin. This commit updates the bootstrap logic to handle the
--check flag the same way regardless of whether the code is piped from
stdin.

Fixes: nodejs#11680
    @not-an-aardvark
    not-an-aardvark committed Apr 1, 2017
    Configuration menu
    Copy the full SHA
    6e255ad View commit details
    Browse the repository at this point in the history

  2. squash: ensure the filename is still used

    @not-an-aardvark
    not-an-aardvark committed Apr 1, 2017
    Configuration menu
    Copy the full SHA
    bc820d5 View commit details
    Browse the repository at this point in the history

  3. cli: throw when -c and -e are used simultaneously 

    The -c flag ("check script syntax") and -e flag ("evaluate given code")
have contradictory meanings. Make them mutually exclusive by throwing
when both of them are provided.
    @not-an-aardvark
    not-an-aardvark committed Apr 1, 2017
    Configuration menu
    Copy the full SHA
    24ad2bf View commit details
    Browse the repository at this point in the history

  4. squash: change exit code to 9 for invalid args

    @not-an-aardvark
    not-an-aardvark committed Apr 1, 2017
    Configuration menu
    Copy the full SHA
    913d121 View commit details
    Browse the repository at this point in the history

  5. squash: remove duplicate word in commit

    @not-an-aardvark
    not-an-aardvark committed Apr 1, 2017
    Configuration menu
    Copy the full SHA
    5578701 View commit details
    Browse the repository at this point in the history

  6. squash: make assertion error message more specific

    @not-an-aardvark
    not-an-aardvark committed Apr 1, 2017
    Configuration menu
    Copy the full SHA
    299155d View commit details
    Browse the repository at this point in the history

  7. squash: move flag validation to c++

    @not-an-aardvark
    not-an-aardvark committed Apr 1, 2017
    Configuration menu
    Copy the full SHA
    fab87a9 View commit details
    Browse the repository at this point in the history