Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(v6.x backport) Doc and test cert apis #12468

Closed
wants to merge 6 commits into from
Closed

(v6.x backport) Doc and test cert apis #12468

wants to merge 6 commits into from

Commits on Apr 17, 2017

  1. test: getgroups() may contain duplicate GIDs 

    Some systems may have multiple group names with the same group ID, in
which case getgroups() returns duplicate values, where `id -G` will
filter the duplicates. Unique and sort the arrays so they can be
compared.

PR-URL: nodejs#10389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @sam-github
    sam-github committed Apr 17, 2017
    Configuration menu
    Copy the full SHA
    cc1d02d View commit details
    Browse the repository at this point in the history

  2. doc,test: tls .ca option supports multi-PEM files 

    PR-URL: nodejs#10389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @sam-github
    sam-github committed Apr 17, 2017
    Configuration menu
    Copy the full SHA
    05039c3 View commit details
    Browse the repository at this point in the history

  3. test: tls cert chain completion scenarios 

    PR-URL: nodejs#10389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @sam-github
    sam-github committed Apr 17, 2017
    Configuration menu
    Copy the full SHA
    d59c9f5 View commit details
    Browse the repository at this point in the history

  4. doc: use correct tls certificate property name 

    Docs referred to an `issuer` property being optionally present, when it
should have referred to the `issuerCertificate` property.

PR-URL: nodejs#10389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @sam-github
    sam-github committed Apr 17, 2017
    Configuration menu
    Copy the full SHA
    7c6aec6 View commit details
    Browse the repository at this point in the history

  5. test: check tls server verification with addCACert 

    SecureContext.addCACert() adds to the existing root store,
preserving root cert entries. option.ca is applied without
calling SecureContext.addRootCerts() so should add to
the default, empty, root store.

This test confirms that the built-in root CAs are not included
when options.ca is used.

Based on:

shigeki@acd5837

PR-URL: nodejs#10389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @sam-github
    sam-github committed Apr 17, 2017
    Configuration menu
    Copy the full SHA
    fd97d25 View commit details
    Browse the repository at this point in the history

  6. test: move common tls connect setup into fixtures 

    TLS connection setup boilerplate is common to many TLS tests, factor it
into a test fixture so tests are clearer to read and faster to write.

PR-URL: nodejs#10389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @sam-github
    sam-github committed Apr 17, 2017
    Configuration menu
    Copy the full SHA
    8db0443 View commit details
    Browse the repository at this point in the history