lib: optimize require() path walking #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Tempted to say add |
Remove a speed bump from commit 36777d2 by reusing the result of the previous stat() system call. It's a code path that gets called many thousands of times at startup in most applications so shaving off an extra system call can have an appreciable impact on startup times. PR-URL: nodejs#130 Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
bnoordhuis
force-pushed
the
optimize-require-path-walking
branch
from
d9faecb
to
ddf17f9
Compare
|
Incorporated feedback and landed in ddf17f9. Thanks, Chris! |
|
just came home, awesome work! :) |
This was referenced Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a speed bump from commit 36777d2 by reusing the result of the
previous stat() system call. It's a code path that gets called many
thousands of times at startup in most applications so shaving off an
extra system call can have an appreciable impact on startup times.
R=@chrisdickinson @robertkowalski