Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: remove redundant timers benchmark #13009

Closed
wants to merge 1 commit into from
Closed

benchmark: remove redundant timers benchmark #13009

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 13, 2017

The immediate.js benchmark with type set to depth measures the same
thing as set-immediate-depth.js. Remove the redundancy.`

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

timers benchmark

@Trott
benchmark: remove redundant timers benchmark
1b5db6d 
The immediate.js benchmark with `type` set to `depth` measures the same
thing as set-immediate-depth.js. Remove the redundancy.`
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels May 13, 2017
@Trott
Copy link
Member Author

Trott commented May 15, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8092/

@Trott
Copy link
Member Author

Trott commented May 17, 2017

Landed in f2ba06d

@Trott Trott closed this May 17, 2017
Trott added a commit to Trott/io.js that referenced this pull request May 17, 2017
@Trott
benchmark: remove redundant timers benchmark
f2ba06d 
The immediate.js benchmark with `type` set to `depth` measures the same
thing as set-immediate-depth.js. Remove the redundancy.`

PR-URL: nodejs#13009
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
@Trott
benchmark: remove redundant timers benchmark
b9b8279 
The immediate.js benchmark with `type` set to `depth` measures the same
thing as set-immediate-depth.js. Remove the redundancy.`

PR-URL: nodejs#13009
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@Trott Trott deleted the timers-bench branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @refack @joyeecheung @MylesBorins @nodejs-github-bot