Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: multiple listen() events fail silently #13149

Closed
wants to merge 1 commit into from
Closed

net: multiple listen() events fail silently #13149

wants to merge 1 commit into from

Commits on Sep 2, 2017

  1. net: multiple listen() events fail silently 

    Problem:
It's possible to run listen()
  on a net.Server that's already listening to a port.
The result is silent failure,
  with the side effect of changing the connectionKey and or pipeName.

Solution:
  throw an error if listen method called more than once.
  close() method should be called between listen() method calls.

Refs: nodejs#8294
Fixes: nodejs#6190
Fixes: nodejs#11685
    @eduardbme
    eduardbme committed Sep 2, 2017
    Configuration menu
    Copy the full SHA
    2cd52c9 View commit details
    Browse the repository at this point in the history