Commits on Aug 1, 2017

1. gyp: show descriptive Windows SDK detection error …

   When building with Visual Studio 2017, gyp may fail with a
   non-descriptive message if Windows has stale registry keys for a
   version of Windows SDK that was previously uninstalled.
   
   This commit adds a specific warning message when the directory for
   a detected SDK version doesn't exist and adds some fixes to avoid
   Python crashes that were blocking the detection of other SDK
   versions:
   
   - Only try to run listdir on a path if it exists and is a dir.
   
   - Avoid accessing names[0] if it has no elements.
   
   - Use %s instead of %o to print compatible_sdks (to avoid TypeError,
   since %o is the octal number format specifier in Python and %s can be
   used as a generic format specifier for objects).
   
   Fixes: nodejs#14103

   

   jaimecbernardo committed Aug 1, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for 4715d00
   • Browse repository at this point

   Copy the full SHA

   4715d00 View commit details

   Browse the repository at this point in the history