Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: ensure WriteWrap references the handle #1590

Closed
wants to merge 1 commit into from
Closed

net: ensure WriteWrap references the handle #1590

wants to merge 1 commit into from

Commits on May 2, 2015

  1. net: ensure WriteWrap references the handle 

    `StreamBase::AfterWrite` is passing handle as an argument to the
`afterWrite` function in net.js. Thus GC should not collect the handle
and the request separately and assume that they are tied together.

With this commit - request will always outlive the StreamBase instance,
helping us survive the GC pass.

Fix: nodejs#1580
    @indutny
    indutny committed May 2, 2015
    Configuration menu
    Copy the full SHA
    146bea1 View commit details
    Browse the repository at this point in the history