Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x backport] inspector: overhaul JS binding implementation #16071

Closed
wants to merge 2 commits into from
Closed

[v8.x backport] inspector: overhaul JS binding implementation #16071

wants to merge 2 commits into from

Conversation

TimothyGu
Copy link
Member

Backport #15643.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v8.x labels Oct 7, 2017
@TimothyGu
Copy link
Member Author

TimothyGu commented Oct 7, 2017 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/10479/ (eventually it's going up)

@TimothyGu
Copy link
Member Author

CI is green. Will wait another day before landing (@MylesBorins).

@TimothyGu
module: add inspector to builtinLibs
d263b79 
Backport-PR-URL: nodejs#16071
PR-URL: nodejs#15643
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TimothyGu
inspector: reimplement JS binding
2b17c6a 
- Group all relevant methods/states into a C++ class.
- Uses internal fields instead of the less efficient v8::External for
  storing the pointer to the C++ object.
- Use AsyncWrap to allow instrumenting callback states.

Backport-PR-URL: nodejs#16071
PR-URL: nodejs#15643
Refs: nodejs#13503
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Oct 23, 2017
@TimothyGu @evanlucas
module: add inspector to builtinLibs
25c9803 
Backport-PR-URL: #16071
PR-URL: #15643
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Oct 23, 2017
@TimothyGu @evanlucas
inspector: reimplement JS binding
b431a49 
- Group all relevant methods/states into a C++ class.
- Uses internal fields instead of the less efficient v8::External for
  storing the pointer to the C++ object.
- Use AsyncWrap to allow instrumenting callback states.

Backport-PR-URL: #16071
PR-URL: #15643
Refs: #13503
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas
Copy link
Contributor

Landed in 25c9803 and b431a49. Thanks!

@evanlucas evanlucas closed this Oct 23, 2017
@TimothyGu TimothyGu deleted the v8.x-15643 branch March 26, 2018 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TimothyGu @evanlucas @addaleax @nodejs-github-bot