Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: Fixing NameError #1628

Closed
wants to merge 1 commit into from
Closed

Conversation

thefourtheye
Copy link
Contributor

If len(args) is lesser than two, then install_path = dst_dir + node_prefix + '/' would throw a NameError, because dst_dir will not be defined yet. So, we are assigning an empty string as the default value, if len(args) is lesser than or equal to two.

@Fishrock123 Fishrock123 added the build Issues and PRs related to build files or the CI. label May 5, 2015
@mscdex
Copy link
Contributor

mscdex commented May 5, 2015

The commit message should have a subsystem prefix like tools: or maybe build:

@bnoordhuis
Copy link
Member

What @mscdex said, see e.g. 72f1b34 for an example. Apart from that LGTM.

@thefourtheye thefourtheye force-pushed the patch-1 branch 2 times, most recently from f151947 to 850610c Compare May 5, 2015 17:49
If `len(args)` is lesser than two, then
`install_path = dst_dir + node_prefix + '/'` would throw a `NameError`,
because `dst_dir` will not be defined yet. So we are assigning `''` as
the default value.
@thefourtheye
Copy link
Contributor Author

@mscdex @bnoordhuis Thanks Guys. I force pushed my commit. Please check now.

@thefourtheye thefourtheye changed the title Fixing NameError install: Fixing NameError May 6, 2015
Fishrock123 pushed a commit that referenced this pull request May 7, 2015
If `len(args)` is less than two, then
`install_path = dst_dir + node_prefix + '/'` would throw a `NameError`,
because `dst_dir` will not be defined yet. So we are assigning `''` as
the default value.

PR-URL: #1628
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123
Copy link
Contributor

Thanks, landed in b97b96d

@Fishrock123 Fishrock123 closed this May 7, 2015
@thefourtheye thefourtheye deleted the patch-1 branch May 7, 2015 16:45
@rvagg rvagg mentioned this pull request May 7, 2015
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 19, 2015
If `len(args)` is less than two, then
`install_path = dst_dir + node_prefix + '/'` would throw a `NameError`,
because `dst_dir` will not be defined yet. So we are assigning `''` as
the default value.

PR-URL: nodejs#1628
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants