Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix pedantic cpplint whitespace warnings #1640

Merged
merged 1 commit into from
May 6, 2015

Conversation

bnoordhuis
Copy link
Member

Introduced in commit b712af7 ("src: fix NODE_DEPRECATED macro with old
compilers").

R=@silverwind

bnoordhuis referenced this pull request May 6, 2015
The `__attribute__((deprecated("warning")))` macro didn't exist until
gcc 4.5 and clang 2.9.

While io.js does not build with compilers that old, add-ons do.  Let's
make src/node.h compatible with such compilers, it's a public header.

PR-URL: #1626
Refs: #1619
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@silverwind
Copy link
Contributor

Linter is happy, LGTM

Introduced in commit b712af7 ("src: fix NODE_DEPRECATED macro with old
compilers").

PR-URL: nodejs#1640
Reviewed-By: Roman Reiss <me@silverwind.io>
@bnoordhuis bnoordhuis closed this May 6, 2015
@bnoordhuis bnoordhuis deleted the fix-cpplint-warnings branch May 6, 2015 15:27
@bnoordhuis bnoordhuis merged commit 8315b22 into nodejs:master May 6, 2015
@rvagg rvagg mentioned this pull request May 7, 2015
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 19, 2015
Introduced in commit b712af7 ("src: fix NODE_DEPRECATED macro with old
compilers").

PR-URL: nodejs#1640
Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants