Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove custom message from assertion #16824

Closed
wants to merge 1 commit into from
Closed

test: remove custom message from assertion #16824

wants to merge 1 commit into from

Conversation

Marsup
Copy link
Contributor

@Marsup Marsup commented Nov 6, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. test Issues and PRs related to the tests. labels Nov 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2017
@Trott
Copy link
Member

Trott commented Nov 7, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11245/

@Trott
Copy link
Member

Trott commented Nov 7, 2017

Something was up with CI. Let's try again.

CI: https://ci.nodejs.org/job/node-test-pull-request/11252/

@Trott
Copy link
Member

Trott commented Nov 7, 2017

Landed in 2054c66.
Thanks for the contribution! 🎉

@Trott Trott closed this Nov 7, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 7, 2017
@Marsup @Trott
test: remove custom message from assertion
2054c66 
The custom message means that the values involved are not reported.
Remove the custom message for a more detailed error message.

PR-URL: nodejs#16824
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 7, 2017
@Marsup @cjihrig
test: remove custom message from assertion
527ddda 
The custom message means that the values involved are not reported.
Remove the custom message for a more detailed error message.

PR-URL: nodejs#16824
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@cjihrig cjihrig mentioned this pull request Nov 7, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@Marsup @MylesBorins
test: remove custom message from assertion
562d8fc 
The custom message means that the values involved are not reported.
Remove the custom message for a more detailed error message.

PR-URL: #16824
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
addons Issues and PRs related to native addons. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Marsup @Trott @apapirovski @cjihrig @gireeshpunathil @MylesBorins @nodejs-github-bot