Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: major update to internals #17105

Closed
wants to merge 2 commits into from

Commits on Nov 20, 2017

  1. http2: major update to internals

    This update does several significant things:
    
    1. It eliminates the base Nghttp2* classes and folds those
       in to node::http2::Http2Session and node::http2::Http2Stream
    2. It makes node::http2::Http2Stream a StreamBase instance and
       sends that out to JS-land to act as the [kHandle] for the
       JavaScript Http2Stream class.
    3. It shifts some of the callbacks from C++ off of the JavaScript
       Http2Session class to the Http2Stream class.
    4. It refactors the data provider structure for FD and Stream
       based sending to help encapsulate those functions easier
    5. It streamlines some of the functions at the C++ layer to
       eliminate now unnecessary redirections
    6. It cleans up node_http2.cc for better readability and
       maintainability
    7. It refactors some of the debug output
    8. Because Http2Stream instances are now StreamBases, they are
       now also trackable using async-hooks
    9. The Stream::OnRead algorithm has been simplified with a
       couple bugs fixed.
    10. I've eliminated node_http2_core.h and node_http2_core-inl.h
    11. Detect invalid handshake a report protocol error to session
    12. Refactor out of memory error, improve other errors
    13. Add Http2Session.prototype.ping
    jasnell committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    a21dca0 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2017

  1. [Squash] Fix nits

    jasnell committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    b05f1dc View commit details
    Browse the repository at this point in the history