doc: fix typo in TextEncoding section #18201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
starkwang
approved these changes
Jan 17, 2018
starkwang
added
the
fast-track
benjamingr
approved these changes
Jan 17, 2018
vsemozhetbyt
approved these changes
Jan 17, 2018
vsemozhetbyt
added
the
author ready
|
@vsemozhetbyt I've missed the memo - what's test-pull-request-lite 😮 ? |
|
It is a linter test + linuxone job including doc building, if I get it right — so this is a handy minimum for just doc PRs. |
XadillaX
approved these changes
Jan 17, 2018
|
@vsemozhetbyt very nice! |
richardlau
approved these changes
Jan 17, 2018
cjihrig
approved these changes
Jan 17, 2018
jasnell
approved these changes
Jan 17, 2018
|
CI looks green, going to land this to demonstrate the Node.js process in 2 hours to non-core people if you don't mind (if anyone feels strongly feel free to land before). |
|
Landed in 98f744c |
benjamingr
pushed a commit
that referenced
this pull request
Jan 17, 2018
PR-URL: #18201 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
addaleax
removed
the
author ready
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
PR-URL: #18201 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
PR-URL: #18201 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just found a typo in TextEncoding section to gather util api docs.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc