v9.6.1 proposal #18946
Merged
v9.6.1 proposal #18946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line setting this was removed in a previous commit. This potentially breaks code in the wild using this property. Refs: #17403 (comment) PR-URL: #18944 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
nodejs-github-bot
added
events
MylesBorins
force-pushed
the
v9.6.1-proposal
branch
from
ef60f8d
to
580e507
Compare
MylesBorins
force-pushed
the
v9.6.1-proposal
branch
from
580e507
to
920274c
Compare
cjihrig
approved these changes
Feb 23, 2018
richardlau
approved these changes
Feb 23, 2018
richardlau
reviewed
Feb 23, 2018
CHANGELOG.md
Outdated
| @@ -29,7 +29,8 @@ release. | |||
| </tr> | |||
| <tr> | |||
| <td valign="top"> | |||
| <b><a href="doc/changelogs/CHANGELOG_V9.md#9.6.0">9.6.0</a></b><br/> | |||
| <b><a href="doc/changelogs/CHANGELOG_V9.md#9.6.1">9.6.1</a></b><br/> | |||
| <a href="doc/changelogs/CHANGELOG_V9.md#9.56.0">9.6.0</a><br/> | |||
There was a problem hiding this comment.
Typo in href. Should be #9.6.0.
richardlau
reviewed
Feb 23, 2018
doc/changelogs/CHANGELOG_V9.md
Outdated
| @@ -8,6 +8,7 @@ | |||
| </tr> | |||
| <tr> | |||
| <td> | |||
| <a href="#9.6.0">9.6.1</a><br/> | |||
Notable changes:
* events:
- `events.usingDomains` being set to false by default was removed in
9.6.0 which was a change in behavior compared to 9.5.0. This
behavior change has been reverted and the `events` object now has
`usingDomains` preset to `false`, which is the behavior in 9.x
prior to 9.6.0 (Myles Borins)
#18944
PR-URL: #18946
MylesBorins
force-pushed
the
v9.6.1-proposal
branch
from
920274c
to
0643e3e
Compare
MylesBorins
added a commit
that referenced
this pull request
Feb 23, 2018
Notable changes:
* events:
- `events.usingDomains` being set to false by default was removed in
9.6.0 which was a change in behavior compared to 9.5.0. This
behavior change has been reverted and the `events` object now has
`usingDomains` preset to `false`, which is the behavior in 9.x
prior to 9.6.0 (Myles Borins)
#18944
PR-URL: #18946
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Notable changes:
* events:
- `events.usingDomains` being set to false by default was removed in
9.6.0 which was a change in behavior compared to 9.5.0. This
behavior change has been reverted and the `events` object now has
`usingDomains` preset to `false`, which is the behavior in 9.x
prior to 9.6.0 (Myles Borins)
nodejs#18944
PR-URL: nodejs#18946
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2018-02-22, Version 9.6.1 (Current), @MylesBorins
This is a special release to fix potentially Semver-Major regression that was released in v9.6.0
Notable Changes
events.usingDomainsbeing set tofalseby default was removed in 9.6.0 which was a change in behavior compares to 9.5.0. This behavior change has been reverted and theeventsobject now hasusingDomainspreset tofalse, which is the behavior in 9.x prior to 9.6.0 (Myles Borins) #18944Commits
761caec379] - events: presetusingDomainsto false (Myles Borins) #18944