-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: Add support to cluster to work with `NODE_OPTIONS="--inspect" #19165
Closed
Closed
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
19c4ec3
cluster: Add support to cluster to work with NODE_OPTIONS="--inspect"
sameer-coder ac832ab
cluster: Added test which spawns multiple workers for cluster to …
sameer-coder eb8f567
cluster: Changed multi-line template string in test-inspect-support-f…
sameer-coder ff81da0
cluster: spawning multiple workers in test-inspect-support-for-node_o…
sameer-coder d2cf4a4
cluster: Using common.mustCall to wrap callback in test-inspect-suppo…
sameer-coder 907b8ff
cluster: const numWorkers added in test-inspect-support-for-node_options
sameer-coder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const cluster = require('cluster'); | ||
const assert = require('assert'); | ||
|
||
common.skipIfInspectorDisabled(); | ||
|
||
checkForInspectSupport('--inspect'); | ||
|
||
function checkForInspectSupport(flag) { | ||
|
||
const nodeOptions = JSON.stringify(flag); | ||
process.env.NODE_OPTIONS = flag; | ||
|
||
if (cluster.isMaster) { | ||
for (let i = 0; i < 2; i++) { | ||
cluster.fork(); | ||
} | ||
|
||
cluster.on('online', (worker) => { | ||
worker.disconnect(); | ||
}); | ||
|
||
cluster.on('exit', common.mustCall((worker, code, signal) => { | ||
const errMsg = `For NODE_OPTIONS ${nodeOptions}, failed to start cluster`; | ||
assert.strictEqual(worker.exitedAfterDisconnect, true, errMsg); | ||
}, 2)); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny nit: maybe make the
2
here and in the for loop that forks the workers a const since they should match?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richardlau I have added the const and replaced the
2
both in the for loop and callback.