Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: move Environment ctor/dtor into env.cc #19202

Closed
wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Mar 7, 2018

Splitting out from #18936:

This makes it easier to use methods from other headers
in the constructor and destructor.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes (presumably)
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 7, 2018
@addaleax
Copy link
Member Author

addaleax commented Mar 7, 2018

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 7, 2018
@addaleax addaleax force-pushed the env-cdtor-envcc branch 3 times, most recently from 9ab1d5a to 2260798 Compare March 7, 2018 19:46
This makes it easier to use methods from other headers
in the constructor and destructor.
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 11, 2018
This makes it easier to use methods from other headers
in the constructor and destructor.

PR-URL: nodejs#19202
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR
Copy link
Member

Landed in e0bd2f3 🎉

@MylesBorins
Copy link
Contributor

Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

@addaleax addaleax deleted the env-cdtor-envcc branch April 14, 2018 16:18
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 14, 2018
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
This makes it easier to use methods from other headers
in the constructor and destructor.

PR-URL: nodejs#19202
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax added a commit to addaleax/node that referenced this pull request Jun 30, 2018
This makes it easier to use methods from other headers
in the constructor and destructor.

PR-URL: nodejs#19202
MylesBorins pushed a commit that referenced this pull request Jul 13, 2018
This makes it easier to use methods from other headers
in the constructor and destructor.

Backport-PR-URL: #21599
PR-URL: #19202
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
This makes it easier to use methods from other headers
in the constructor and destructor.

Backport-PR-URL: #21599
PR-URL: #19202
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants