Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: remove hasCallback from listen function #20490

Closed
wants to merge 1 commit into from
Closed

net: remove hasCallback from listen function #20490

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented May 3, 2018

This commit removes hasCallback which is declared as var but
only used once in the line following the declaration and never
reassigned.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
net: remove hasCallback from listen function
207c1fe 
This commit removes hasCallback which is declared as var but
only used once in the line following the declaration and never
reassigned.
@nodejs-github-bot nodejs-github-bot added the net Issues and PRs related to the net subsystem. label May 3, 2018
@danbev
Copy link
Contributor Author

danbev commented May 3, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14645/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 5, 2018
@addaleax
Copy link
Member

addaleax commented May 6, 2018

Landed in 161182e

@addaleax addaleax closed this May 6, 2018
@danbev danbev deleted the net_remove_hasCallback branch May 31, 2018 05:42
@snyk-bot snyk-bot mentioned this pull request Mar 18, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@danbev @addaleax @apapirovski @jasnell @lpinca @cjihrig @BridgeAR @nodejs-github-bot