Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add "Edit on GitHub" link #21703

Closed
wants to merge 5 commits into from
Closed

doc: add "Edit on GitHub" link #21703

wants to merge 5 commits into from
+16 −1

Commits on Jul 13, 2018

  1. doc: add "Edit on GitHub" link 

    Proof of concept for an "Edit on GitHub" link, inspired by the
Serverless docs.

One issue is that the link is to the version of the docs on the master
branch even if the person was reading a different version of the doc. I
don't consider that a big problem, although we can always remove the
link if it turns out to be a big problem. I don't think there is a good
solution. PRs need to be opened against the master branch generally.
Having a bunch of PRs against staging branches is probably not what we
want. If there's an update to one version of the doc, there will usually
be an update to other versions.
    @Trott
    Trott committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    7252864 View commit details
    Browse the repository at this point in the history

  2. squash! update svg per silverwind

    @Trott
    Trott committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    9d6f38d View commit details
    Browse the repository at this point in the history

  3. squash! move css and svg to own files

    @Trott
    Trott committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    3620da2 View commit details
    Browse the repository at this point in the history

  4. squash! do not include edit-on-github link in all.html

    @Trott
    Trott committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    d0df43f View commit details
    Browse the repository at this point in the history

  5. squash! move svg inline again

    @Trott
    Trott committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    c69cae7 View commit details
    Browse the repository at this point in the history