Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove timeout from test-pipe-stream #21837

Closed
wants to merge 1 commit into from
Closed

test: remove timeout from test-pipe-stream #21837

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

The timeout is unnecessary and the suspected cause of the following
failure (even though I could not reproduce it locally):

11:53:54 not ok 197 parallel/test-pipe-stream
11:53:54   ---
11:53:54   duration_ms: 6.253
11:53:54   severity: fail
11:53:54   exitcode: 1
11:53:54   stack: |-
11:53:54     assert.js:338
11:53:54         throw err;
11:53:54         ^
11:53:54
11:53:54     AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
11:53:54
11:53:54       assert.ok(have_ping)
11:53:54
11:53:54         at check (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:14:12)
11:53:54         at Server.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:61:5)
11:53:54         at Server.emit (events.js:182:13)
11:53:54         at emitCloseNT (net.js:1668:8)
11:53:54         at process._tickCallback (internal/process/next_tick.js:63:19)

(From https://ci.nodejs.org/job/node-test-binary-arm/2235/RUN_SUBSET=5,label=pi3-docker/console.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
test: remove timeout from test-pipe-stream
c37c013 
The timeout is unnecessary and the suspected cause of the following
failure (even though I could not reproduce it locally):

    11:53:54 not ok 197 parallel/test-pipe-stream
    11:53:54   ---
    11:53:54   duration_ms: 6.253
    11:53:54   severity: fail
    11:53:54   exitcode: 1
    11:53:54   stack: |-
    11:53:54     assert.js:338
    11:53:54         throw err;
    11:53:54         ^
    11:53:54
    11:53:54     AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
    11:53:54
    11:53:54       assert.ok(have_ping)
    11:53:54
    11:53:54         at check (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:14:12)
    11:53:54         at Server.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:61:5)
    11:53:54         at Server.emit (events.js:182:13)
    11:53:54         at emitCloseNT (net.js:1668:8)
    11:53:54         at process._tickCallback (internal/process/next_tick.js:63:19)

(From https://ci.nodejs.org/job/node-test-binary-arm/2235/RUN_SUBSET=5,label=pi3-docker/console.)
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/286/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 16, 2018
@Trott
Copy link
Member

Trott commented Jul 16, 2018

@addaleax (or anyone else curious, in case @addaleax already knows this): I'm able to reproduce locally by reducing the timeout to 200 rather than 2000 and running a bunch of tests simultaneously. Or you can go the really easy route and reduce the timeout to 1.

@addaleax addaleax added net Issues and PRs related to the net subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Jul 17, 2018
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/15932/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 18, 2018
@addaleax
Copy link
Member Author

ARM re-build: https://ci.nodejs.org/job/node-test-commit-arm-fanned/2404/

@addaleax
Copy link
Member Author

Landed in 36a15a1

@addaleax addaleax closed this Jul 26, 2018
@addaleax addaleax deleted the test-pipe-stream-no-timeout branch July 26, 2018 11:59
addaleax added a commit that referenced this pull request Jul 26, 2018
@addaleax
test: remove timeout from test-pipe-stream
36a15a1 
The timeout is unnecessary and the suspected cause of the following
failure (even though I could not reproduce it locally):

    11:53:54 not ok 197 parallel/test-pipe-stream
    11:53:54   ---
    11:53:54   duration_ms: 6.253
    11:53:54   severity: fail
    11:53:54   exitcode: 1
    11:53:54   stack: |-
    11:53:54     assert.js:338
    11:53:54         throw err;
    11:53:54         ^
    11:53:54
    11:53:54     AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
    11:53:54
    11:53:54       assert.ok(have_ping)
    11:53:54
    11:53:54         at check (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:14:12)
    11:53:54         at Server.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:61:5)
    11:53:54         at Server.emit (events.js:182:13)
    11:53:54         at emitCloseNT (net.js:1668:8)
    11:53:54         at process._tickCallback (internal/process/next_tick.js:63:19)

(From https://ci.nodejs.org/job/node-test-binary-arm/2235/RUN_SUBSET=5,label=pi3-docker/console.)

PR-URL: #21837
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 26, 2018
@addaleax @targos
test: remove timeout from test-pipe-stream
4958501 
The timeout is unnecessary and the suspected cause of the following
failure (even though I could not reproduce it locally):

    11:53:54 not ok 197 parallel/test-pipe-stream
    11:53:54   ---
    11:53:54   duration_ms: 6.253
    11:53:54   severity: fail
    11:53:54   exitcode: 1
    11:53:54   stack: |-
    11:53:54     assert.js:338
    11:53:54         throw err;
    11:53:54         ^
    11:53:54
    11:53:54     AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
    11:53:54
    11:53:54       assert.ok(have_ping)
    11:53:54
    11:53:54         at check (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:14:12)
    11:53:54         at Server.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:61:5)
    11:53:54         at Server.emit (events.js:182:13)
    11:53:54         at emitCloseNT (net.js:1668:8)
    11:53:54         at process._tickCallback (internal/process/next_tick.js:63:19)

(From https://ci.nodejs.org/job/node-test-binary-arm/2235/RUN_SUBSET=5,label=pi3-docker/console.)

PR-URL: #21837
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jul 31, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. flaky-test Issues and PRs related to the tests with unstable failures on the CI. net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@addaleax @nodejs-github-bot @Trott @jasnell @lpinca @cjihrig