Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8: move serdes to internalBinding #22161

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Aug 6, 2018

Refs: #22160

/cc @addaleax @jasnell

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 6, 2018
@devsnek
Copy link
Member Author

devsnek commented Aug 6, 2018

@maclover7 maclover7 added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 6, 2018
@maclover7
Copy link
Contributor

CITGM (sqlite3 and winston have been flaky as of late): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1489/

Copy link
Contributor

@maclover7 maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CITGM results look okay, LGTM if CI passes

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PR-URL: nodejs#22161
Refs: nodejs#22160
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@devsnek
Copy link
Member Author

devsnek commented Aug 8, 2018

landed in cf3bb59

@devsnek devsnek closed this Aug 8, 2018
@devsnek devsnek deleted the serdes-to-internal branch August 8, 2018 22:26
@devsnek devsnek restored the serdes-to-internal branch August 8, 2018 22:26
@devsnek devsnek merged commit cf3bb59 into nodejs:master Aug 8, 2018
@devsnek devsnek deleted the serdes-to-internal branch August 8, 2018 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.