Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove string argument from strict.Equal() #22718

Closed
wants to merge 1 commit into from

Conversation

Hariss096
Copy link
Contributor

Removing string literal passed as argument to assert.strictEqual() in order to print the expected value instead of the string. (First issue assigned through Email by Rich Trott)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Removing string literal passed as argument to assert.strictEqual() in order to print the expected value instead of the string. (First issue assigned through Email by Rich Trott)
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 5, 2018
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quotes can probably be dropped now that the text is in a comment, but LGTM

@trivikr
Copy link
Member

trivikr commented Sep 6, 2018

@trivikr
Copy link
Member

trivikr commented Sep 6, 2018

@danbev
Copy link
Contributor

danbev commented Sep 9, 2018

Landed in 5977f28.

@danbev danbev closed this Sep 9, 2018
danbev pushed a commit that referenced this pull request Sep 9, 2018
Removing string literal passed as argument to assert.strictEqual() in
order to print the expected value instead of the string. (First issue
assigned through Email by Rich Trott)

PR-URL: #22718
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member

Trott commented Sep 9, 2018

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Hariss096
Copy link
Contributor Author

Thank you all very much for your great support.

targos pushed a commit that referenced this pull request Sep 10, 2018
Removing string literal passed as argument to assert.strictEqual() in
order to print the expected value instead of the string. (First issue
assigned through Email by Rich Trott)

PR-URL: #22718
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants