Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: align argument names #22760

Closed
wants to merge 2 commits into from
Closed

assert: align argument names #22760

wants to merge 2 commits into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Sep 8, 2018

This makes sure the documented argument names and the ones thrown
in errors is aligned with the actual argument name.

This addresses the comment from @Trott #22692 (comment).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
assert: align argument names
8ed2bc4 
This makes sure the documented argument names and the ones thrown
in errors is aligned with the actual argument name.
@BridgeAR BridgeAR requested a review from Trott September 8, 2018 00:34
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/831/pipeline

@nodejs-github-bot nodejs-github-bot added the assert Issues and PRs related to the assert subsystem. label Sep 8, 2018
Trott
Trott approved these changes Sep 8, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick fix.

@BridgeAR
Copy link
Member Author

BridgeAR commented Sep 8, 2018

CI https://ci.nodejs.org/job/node-test-pull-request/17081/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 8, 2018
lundibundi
lundibundi approved these changes Sep 8, 2018
View reviewed changes
Copy link
Member

@lundibundi lundibundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice reformatting 👍

test/parallel/test-net-connect-options-port.js Outdated
noop);
for (const block of portHostOptBlocks) {
block();
const portHostOptFns = doConnect([{ port: port, host: 'localhost' }], noop);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{ port, host: 'localhost' } ?

test/parallel/test-net-connect-options-port.js Outdated
dont);
for (const block of portHostOptBlocks) {
block().on('error', onError());
const portHostOptFns = doConnect([{ port: port, host: 'localhost' }], dont);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

@BridgeAR
Copy link
Member Author

BridgeAR commented Sep 9, 2018

Comments addressed.

CI https://ci.nodejs.org/job/node-test-pull-request/17097/

@BridgeAR
Copy link
Member Author

BridgeAR commented Sep 11, 2018 •
edited
Loading

Resumbed CI: https://ci.nodejs.org/job/node-test-commit/21362/ ✔️ (besides windows that is rerun afterwards)

@BridgeAR
Copy link
Member Author

BridgeAR commented Sep 11, 2018 •
edited
Loading

Rerunning Windows: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20664/ ✔️

@BridgeAR
Copy link
Member Author

Landed in b5430d7

@BridgeAR BridgeAR closed this Sep 11, 2018
BridgeAR added a commit to BridgeAR/node that referenced this pull request Sep 11, 2018
@BridgeAR
assert: align argument names
b5430d7 
This makes sure the documented argument names and the ones thrown
in errors is aligned with the actual argument name.

PR-URL: nodejs#22760
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
targos pushed a commit that referenced this pull request Sep 12, 2018
@BridgeAR @targos
assert: align argument names
108a169 
This makes sure the documented argument names and the ones thrown
in errors is aligned with the actual argument name.

PR-URL: #22760
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
@targos targos removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v10.x labels Sep 12, 2018
@targos targos mentioned this pull request Sep 18, 2018
Merged
targos pushed a commit that referenced this pull request Sep 19, 2018
@BridgeAR @targos
assert: align argument names
52877ee 
This makes sure the documented argument names and the ones thrown
in errors is aligned with the actual argument name.

PR-URL: #22760
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
targos pushed a commit that referenced this pull request Sep 20, 2018
@BridgeAR @targos
assert: align argument names
0015430 
This makes sure the documented argument names and the ones thrown
in errors is aligned with the actual argument name.

PR-URL: #22760
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
@BridgeAR BridgeAR deleted the improve-assert-block-name branch January 20, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@hiroppy hiroppy hiroppy approved these changes

@lundibundi lundibundi lundibundi approved these changes

@trivikr trivikr trivikr approved these changes

@mihalskiy mihalskiy mihalskiy approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@BridgeAR @nodejs-github-bot @jasnell @Trott @lpinca @hiroppy @lundibundi @trivikr @mihalskiy @targos