build: remove unnecessary Makefile output #23129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
lpinca
approved these changes
Sep 27, 2018
|
cc: @danbev |
Trott
added
the
author ready
|
SmartOS rebuild: https://ci.nodejs.org/job/node-test-commit-smartos/20536/ ✔️ Windows rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/21082/ ✔️ |
thefourtheye
approved these changes
Sep 27, 2018
richardlau
approved these changes
Sep 27, 2018
cjihrig
approved these changes
Sep 28, 2018
refack
approved these changes
Sep 28, 2018
👍 I'm all for removing them! They were not really comments before, they were still outputted as they were indented and passed to the shell. |
jasnell
approved these changes
Sep 28, 2018
|
Landed in a79c88a |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 1, 2018
Remove unnecessary @echo commands from Makefile. These were originally comments but were changed to @echo in 6bc43ae. They aren't terribly useful so let's remove them. PR-URL: nodejs#23129 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 1, 2018
Remove unnecessary @echo commands from Makefile. These were originally comments but were changed to @echo in 6bc43ae. They aren't terribly useful so let's remove them. PR-URL: #23129 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 3, 2018
Remove unnecessary @echo commands from Makefile. These were originally comments but were changed to @echo in 6bc43ae. They aren't terribly useful so let's remove them. PR-URL: #23129 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary @echo commands from Makefile.
These were originally comments but were changed to @echo in 6bc43ae.
They aren't terribly useful so let's remove them.
👍 here to fast-track.
@nodejs/build-files
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes