Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: added a test benchmark for worker #23475

Closed
wants to merge 1 commit into from
Closed

benchmark: added a test benchmark for worker #23475

wants to merge 1 commit into from

Conversation

umarov
Copy link
Contributor

@umarov umarov commented Oct 12, 2018 •
edited
Loading

Wrote a sequential benchmark test for worker.
This is to make sure the benchmark for worker runs properly.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@umarov
benchmark: added a test benchmark for worker
6f78534 
Wrote a sequential benchmark test for worker.
This is to make sure the benchmark for work runs properly.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 12, 2018
@targos targos added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
@Trott
Copy link
Member

Trott commented Oct 14, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17842/

@addaleax addaleax added benchmark Issues and PRs related to the benchmark subsystem. worker Issues and PRs related to Worker support. labels Oct 14, 2018
@addaleax
Copy link
Member

Landed in 8059ff2

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@addaleax addaleax closed this Oct 14, 2018
addaleax pushed a commit that referenced this pull request Oct 14, 2018
@umarov @addaleax
benchmark: added a test benchmark for worker
8059ff2 
Wrote a sequential benchmark test for worker.
This is to make sure the benchmark for work runs properly.

PR-URL: #23475
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax pushed a commit that referenced this pull request Oct 14, 2018
@umarov @addaleax
benchmark: added a test benchmark for worker
fe781bc 
Wrote a sequential benchmark test for worker.
This is to make sure the benchmark for work runs properly.

PR-URL: #23475
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@umarov @jasnell
benchmark: added a test benchmark for worker
cdca587 
Wrote a sequential benchmark test for worker.
This is to make sure the benchmark for work runs properly.

PR-URL: #23475
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@umarov @MylesBorins
benchmark: added a test benchmark for worker
99d39f9 
Wrote a sequential benchmark test for worker.
This is to make sure the benchmark for work runs properly.

PR-URL: #23475
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@umarov @rvagg
benchmark: added a test benchmark for worker
ea43461 
Wrote a sequential benchmark test for worker.
This is to make sure the benchmark for work runs properly.

PR-URL: #23475
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@umarov @MylesBorins
benchmark: added a test benchmark for worker
192c2af 
Wrote a sequential benchmark test for worker.
This is to make sure the benchmark for work runs properly.

PR-URL: #23475
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@umarov @Trott @addaleax @jasnell @cjihrig @trivikr @targos @nodejs-github-bot