Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: undo internalBinding() conversion in compat mechanism #23662

Closed
wants to merge 1 commit into from
Closed

stream: undo internalBinding() conversion in compat mechanism #23662

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Refs: #22675

/cc @nodejs/streams

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1247/pipeline

@addaleax addaleax requested a review from cjihrig October 14, 2018 23:37
@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Oct 14, 2018
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/17859/

@addaleax addaleax mentioned this pull request Oct 14, 2018
Merged
3 tasks
mcollina
mcollina approved these changes Oct 15, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danbev
Copy link
Contributor

danbev commented Oct 18, 2018

Landed in 4e9e0d3.

@danbev danbev closed this Oct 18, 2018
danbev pushed a commit that referenced this pull request Oct 18, 2018
@addaleax @danbev
stream: undo internalBinding() conversion in compat mechanism
4e9e0d3 
PR-URL: #23662
Refs: #22675
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell pushed a commit that referenced this pull request Oct 21, 2018
@addaleax @jasnell
stream: undo internalBinding() conversion in compat mechanism
20373c4 
PR-URL: #23662
Refs: #22675
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@starkwang starkwang starkwang approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@addaleax @nodejs-github-bot @danbev @mcollina @cjihrig @BridgeAR @starkwang @trivikr