Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: for debug mode set v8_optimized_debug #23704

Merged
merged 2 commits into from
Oct 31, 2018
Merged

build: for debug mode set v8_optimized_debug #23704

merged 2 commits into from
Oct 31, 2018

Commits on Oct 31, 2018

  1. build: configure default v8_optimized_debug 

    Under the assumption that debugging is more often focused on node core
source. This setting compiles V8 with only partial optimizations,
DCHECKS, and debug symbols, so it is still very much debuggable,
but it is much faster.

It does disable SLOW_DCHECKS, but at the advice of the V8 team, those
are more important for deep V8 debugging.

Override is configurable with `./configure --v8-non-optimized-debug`.

PR-URL: nodejs#23704
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    @refack
    refack committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    e9dc1eb View commit details
    Browse the repository at this point in the history

  2. deps,v8: fix gypfile bug 

    PR-URL: nodejs#23704
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    @refack
    refack committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    df7f629 View commit details
    Browse the repository at this point in the history