Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fixes order of arguments in assert.strictEqual #24140

Closed
wants to merge 1 commit into from
Closed

test: fixes order of arguments in assert.strictEqual #24140

wants to merge 1 commit into from

Conversation

posth
Copy link
Contributor

@posth posth commented Nov 6, 2018

This PR fixes the order of the arguments of the assert.strictEqual() of test/parallel/test-http-client-upload-buf.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@posth
test: fixes order of arguments in assert.strictEqual
65e3106 
File: test/parallel/test-http-client-upload-buf.js
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2018
@gireeshpunathil
Copy link
Member

let me know if these are coming out of NodeConfEU code & learn, so that it can be labelled appropriately, thanks!

@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2018
@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18393/

@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 7, 2018 •
edited
Loading

pls thumbs up for fast tracking

@gireeshpunathil
Copy link
Member

one test failed in arm, but could not have caused by this change.

01:42:49 not ok 1109 parallel/test-https-host-headers
01:42:49   ---
01:42:49   duration_ms: 1.121
01:42:49   severity: fail
01:42:49   exitcode: 1
01:42:49   stack: |-
01:42:49     test https server listening on port 40551
01:42:49     /home/iojs/build/workspace/node-test-commit-arm/nodes/ubuntu1604-arm64/test/parallel/test-https-host-headers.js:31
01:42:49       throw er;
01:42:49       ^
01:42:49     
01:42:49     Error: socket hang up
01:42:49         at createHangUpError (_http_client.js:330:15)
01:42:49         at TLSSocket.socketOnEnd (_http_client.js:433:23)
01:42:49         at TLSSocket.emit (events.js:187:15)
01:42:49         at endReadableNT (_stream_readable.js:1098:12)
01:42:49         at process.internalTickCallback (internal/process/next_tick.js:72:19)
01:42:49   ...
01:42:49 ok 1110 parallel/test-https-foafssl
01:42:49   ---

@gireeshpunathil
Copy link
Member

re-run to be absolutely sure.
new CI: https://ci.nodejs.org/job/node-test-pull-request/18411/

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 9, 2018
@posth @gireeshpunathil
test: fixe argument order in assert.strictEqual
16a199a 
File: test/parallel/test-http-client-upload-buf.js

PR-URL: nodejs#24140
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@gireeshpunathil
Copy link
Member

landed as 16a199a

thank you @posth for the contribution. Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps/

BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
@posth @BridgeAR
test: fixe argument order in assert.strictEqual
3d19a04 
File: test/parallel/test-http-client-upload-buf.js

PR-URL: #24140
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@posth @kiyomizumia
test: fixe argument order in assert.strictEqual
c987bf9 
File: test/parallel/test-http-client-upload-buf.js

PR-URL: nodejs#24140
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Dec 13, 2018
@posth @codebytere
test: fixe argument order in assert.strictEqual
d9489e1 
File: test/parallel/test-http-client-upload-buf.js

PR-URL: #24140
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@posth @MylesBorins
test: fixe argument order in assert.strictEqual
380789e 
File: test/parallel/test-http-client-upload-buf.js

PR-URL: #24140
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Jan 4, 2019
Merged
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@posth @gireeshpunathil @addaleax @cjihrig @BridgeAR @trivikr @codebytere @nodejs-github-bot