Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: combine contructor, tag, Object into a function #24171

Closed
wants to merge 1 commit into from

Conversation

Paul-Isache
Copy link
Contributor

@Paul-Isache Paul-Isache commented Nov 6, 2018

Combine these parts into a function to be used in multiple parts.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax addaleax added util Issues and PRs related to the built-in util module. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Nov 6, 2018
@addaleax
Copy link
Member

addaleax commented Nov 6, 2018

combine these parts into a function to be used in multiple parts
@addaleax
Copy link
Member

addaleax commented Nov 10, 2018

Landed in 04ccc98

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@addaleax addaleax closed this Nov 10, 2018
addaleax pushed a commit that referenced this pull request Nov 10, 2018
combine these parts into a function to be used in multiple parts

PR-URL: #24171
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
combine these parts into a function to be used in multiple parts

PR-URL: #24171
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
combine these parts into a function to be used in multiple parts

PR-URL: nodejs#24171
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere pushed a commit that referenced this pull request Dec 14, 2018
combine these parts into a function to be used in multiple parts

PR-URL: #24171
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
combine these parts into a function to be used in multiple parts

PR-URL: #24171
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants