Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: cherry-pick b87d408 from upstream V8 #24272

Closed
wants to merge 1 commit into from

Commits on Nov 9, 2018

  1. deps: cherry-pick b87d408 from upstream V8

    Original commit message:
    
        [heap-profiler] Fix a use-after-free when snapshots are deleted
    
        If a caller starts the sampling heap profiler and takes a snapshot, and
        then deletes the snapshot before the sampling has completed, a
        use-after-free will occur on the StringsStorage pointer.
    
        The same issue applies for StartTrackingHeapObjects which shares the
        same StringsStorage object.
    
        Bug: v8:8373
        Change-Id: I5d69d60d3f9465f9dd3b3bef107c204e0fda0643
        Reviewed-on: https://chromium-review.googlesource.com/c/1301477
        Commit-Queue: Peter Marshall <petermarshall@chromium.org>
        Reviewed-by: Alexei Filippov <alph@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#57114}
    
    Refs: v8/v8@b87d408
    psmarshall committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    3c82202 View commit details
    Browse the repository at this point in the history