Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-vm-timeout-escape-queuemicrotask #24296

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 11, 2018

Use a larger timeout on slower platforms so that the timeout doesn't
fire before the error condition occurs.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott added the wip Issues and PRs that are still a work in progress. label Nov 11, 2018
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 11, 2018
@Trott
Copy link
Member Author

Trott commented Nov 11, 2018

Stress test against master, will hopefully show failures: https://ci.nodejs.org/view/All/job/node-stress-single-test-pi1-fanned/102/

@Trott
Copy link
Member Author

Trott commented Nov 11, 2018

Stress test against this PR in its current form: https://ci.nodejs.org/view/All/job/node-stress-single-test-pi1-fanned/103/

@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. and removed wip Issues and PRs that are still a work in progress. labels Nov 11, 2018
@Trott
Copy link
Member Author

Trott commented Nov 11, 2018

Pi1 on master had 67 failures in 100 runs. With this PR, 0 failures in 100 runs. Let's land this...

@Trott
Copy link
Member Author

Trott commented Nov 11, 2018

Requesting fast-track. Collaborators, please 👍 here to approve.

Use a larger timeout on slower platforms so that the timeout doesn't
fire before the error condition occurs.
@Trott
Copy link
Member Author

Trott commented Nov 11, 2018

@Trott
Copy link
Member Author

Trott commented Nov 11, 2018

Force-pushed a change. Only difference is that I removed this test from flaky status in known_issues.status file.

CI: https://ci.nodejs.org/job/node-test-pull-request/18517/

@Trott Trott added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Nov 11, 2018
@Trott
Copy link
Member Author

Trott commented Nov 11, 2018

@nodejs/testing

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 12, 2018
@Trott
Copy link
Member Author

Trott commented Nov 13, 2018

Landed in 8e3c5b5

@Trott Trott closed this Nov 13, 2018
Trott added a commit to Trott/io.js that referenced this pull request Nov 13, 2018
Use a larger timeout on slower platforms so that the timeout doesn't
fire before the error condition occurs.

PR-URL: nodejs#24296
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
Use a larger timeout on slower platforms so that the timeout doesn't
fire before the error condition occurs.

PR-URL: #24296
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
Use a larger timeout on slower platforms so that the timeout doesn't
fire before the error condition occurs.

PR-URL: nodejs#24296
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants