Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Replacing anonymous closure function with arrow function #24439

Closed
wants to merge 6 commits into from
Closed

test: Replacing anonymous closure function with arrow function #24439

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
07b1e64
running test
prabusubra Nov 17, 2018
b7dc917
replacing anonymous closure function with arrow function
prabusubra Nov 17, 2018
1ff4174
replace anonymous closure function with arrow func
prabusubra Nov 17, 2018
4b6d294
Removed extra new line
tpanthera Nov 19, 2018
520b2aa
removed changes on test-http-localaddress.js
tpanthera Nov 20, 2018
4de0029
added back trailing space after release types
tpanthera Nov 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,3 +591,4 @@ Other keys used to sign some previous releases:
[Working Groups]: https://github.com/nodejs/TSC/blob/master/WORKING_GROUPS.md
[Strategic Initiatives]: https://github.com/nodejs/TSC/blob/master/Strategic-Initiatives.md
[#node.js channel on chat.freenode.net]: https://webchat.freenode.net?channels=node.js&uio=d4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is unrelated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi addaleax,
yes, this is mistake. i didn't observe the new line change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prabusubra - you may fix that by removing the extra line and repeating the last 3 steps for the PR process: git add <filename>, git commit , git push origin testcodeimprovements

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks Gireesh

4 changes: 2 additions & 2 deletions test/parallel/test-http-server-stale-close.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ if (process.env.NODE_TEST_FORK_PORT) {
req.write('BAM');
req.end();
} else {
const server = http.createServer(function(req, res) {
const server = http.createServer((req, res) => {
res.writeHead(200, { 'Content-Length': '42' });
req.pipe(res);
req.on('close', function() {
req.on('close', () => {
server.close();
res.end();
});
Expand Down