Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: revise author ready explanation #24558

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 21, 2018

Improve the author ready text in the COLLABORATOR_GUIDE for
scannability, readability, etc.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Improve the `author ready` text in the COLLABORATOR_GUIDE for
scannability, readability, etc.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 21, 2018
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels as if applying/removing the label could be something automatable with the github-bot.

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 21, 2018
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 21, 2018
@Trott
Copy link
Member Author

Trott commented Nov 21, 2018

Landed in 7cc3b1e

@Trott Trott closed this Nov 21, 2018
Trott added a commit to Trott/io.js that referenced this pull request Nov 21, 2018
Improve the `author ready` text in the COLLABORATOR_GUIDE for
scannability, readability, etc.

PR-URL: nodejs#24558
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos pushed a commit that referenced this pull request Nov 24, 2018
Improve the `author ready` text in the COLLABORATOR_GUIDE for
scannability, readability, etc.

PR-URL: #24558
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
Improve the `author ready` text in the COLLABORATOR_GUIDE for
scannability, readability, etc.

PR-URL: #24558
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
4 tasks
codebytere pushed a commit that referenced this pull request Jan 13, 2019
Improve the `author ready` text in the COLLABORATOR_GUIDE for
scannability, readability, etc.

PR-URL: #24558
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Improve the `author ready` text in the COLLABORATOR_GUIDE for
scannability, readability, etc.

PR-URL: nodejs#24558
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@codebytere codebytere mentioned this pull request Jan 15, 2019
codebytere pushed a commit that referenced this pull request Jan 29, 2019
Improve the `author ready` text in the COLLABORATOR_GUIDE for
scannability, readability, etc.

PR-URL: #24558
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
codebytere pushed a commit that referenced this pull request Jan 29, 2019
Improve the `author ready` text in the COLLABORATOR_GUIDE for
scannability, readability, etc.

PR-URL: #24558
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants