doc: revise code review guidelines #24790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revise the Code Reviews section of the Collaborator Guide to remove redundant statements, simplify text and structure for easier comprehension, and remove material that does not reflect current practices.
cjihrig
approved these changes
Dec 2, 2018
lpinca
approved these changes
Dec 2, 2018
targos
approved these changes
Dec 2, 2018
antsmartian
approved these changes
Dec 3, 2018
|
Landed in 83ee137 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 4, 2018
Revise the Code Reviews section of the Collaborator Guide to remove redundant statements, simplify text and structure for easier comprehension, and remove material that does not reflect current practices. PR-URL: nodejs#24790 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Dec 5, 2018
Revise the Code Reviews section of the Collaborator Guide to remove redundant statements, simplify text and structure for easier comprehension, and remove material that does not reflect current practices. PR-URL: #24790 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Dec 7, 2018
Revise the Code Reviews section of the Collaborator Guide to remove redundant statements, simplify text and structure for easier comprehension, and remove material that does not reflect current practices. PR-URL: #24790 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Dec 7, 2018
Revise the Code Reviews section of the Collaborator Guide to remove redundant statements, simplify text and structure for easier comprehension, and remove material that does not reflect current practices. PR-URL: #24790 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Revise the Code Reviews section of the Collaborator Guide to remove redundant statements, simplify text and structure for easier comprehension, and remove material that does not reflect current practices. PR-URL: nodejs#24790 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
Revise the Code Reviews section of the Collaborator Guide to remove redundant statements, simplify text and structure for easier comprehension, and remove material that does not reflect current practices. PR-URL: #24790 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Feb 20, 2019
Revise the Code Reviews section of the Collaborator Guide to remove redundant statements, simplify text and structure for easier comprehension, and remove material that does not reflect current practices. PR-URL: #24790 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Revise the Code Reviews section of the Collaborator Guide to remove redundant statements, simplify text and structure for easier comprehension, and remove material that does not reflect current practices. PR-URL: #24790 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revise the Code Reviews section of the Collaborator Guide to remove
redundant statements, simplify text and structure for easier
comprehension, and remove material that does not reflect current
practices.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes