Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: make internal API warning more direct #25125

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/internal/test/binding.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
'use strict';

process.emitWarning(
'These APIs are exposed only for testing and are not ' +
'tracked by any versioning system or deprecation process.',
'These APIs are for internal testing only. Do not use them.',
'internal/test/binding');

module.exports = { internalBinding };
3 changes: 1 addition & 2 deletions lib/internal/test/heap.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
'use strict';

process.emitWarning(
'These APIs are exposed only for testing and are not ' +
'tracked by any versioning system or deprecation process.',
'These APIs are for internal testing only. Do not use them.',
'internal/test/heap');

const { createHeapDump, buildEmbedderGraph } = internalBinding('heap_utils');
Expand Down
3 changes: 1 addition & 2 deletions test/parallel/test-dns-lookup.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ cares.getaddrinfo = () => internalBinding('uv').UV_ENOENT;
common.expectWarning({
// For 'internal/test/binding' module.
'internal/test/binding': [
'These APIs are exposed only for testing and are not ' +
'tracked by any versioning system or deprecation process.'
'These APIs are for internal testing only. Do not use them.'
],
// For dns.promises.
'ExperimentalWarning': [
Expand Down
3 changes: 1 addition & 2 deletions test/parallel/test-fs-filehandle.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ let fdnum;

common.expectWarning({
'internal/test/binding': [
'These APIs are exposed only for testing ' +
'and are not tracked by any versioning system or deprecation process.',
'These APIs are for internal testing only. Do not use them.',
common.noWarnCode
],
'Warning': [
Expand Down