Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-trace-events-api-worker-disabled flaky #25197

Closed
wants to merge 1 commit into from
Closed

test: mark test-trace-events-api-worker-disabled flaky #25197

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 23, 2018

Refs: #24305

Collaborators, 👍 here to fast-track.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Dec 23, 2018
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2051/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 23, 2018
@Trott
Copy link
Member Author

Trott commented Dec 24, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/19789/ ✔️

@Trott
Copy link
Member Author

Trott commented Dec 24, 2018

Landed in 361cdb7

@Trott Trott closed this Dec 24, 2018
Trott added a commit to Trott/io.js that referenced this pull request Dec 24, 2018
@Trott
test: mark test-trace-events-api-worker-disabled flaky
361cdb7 
Refs: nodejs#24305

PR-URL: nodejs#25197
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
@Trott @MylesBorins
test: mark test-trace-events-api-worker-disabled flaky
1056507 
Refs: #24305

PR-URL: #25197
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 25, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@Trott @MylesBorins
test: mark test-trace-events-api-worker-disabled flaky
6557ea1 
Refs: #24305

PR-URL: #25197
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Trott @refack
test: mark test-trace-events-api-worker-disabled flaky
463e99e 
Refs: nodejs#24305

PR-URL: nodejs#25197
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
@Trott @BethGriggs
test: mark test-trace-events-api-worker-disabled flaky
550cc93 
Refs: #24305

PR-URL: #25197
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@Trott @BethGriggs
test: mark test-trace-events-api-worker-disabled flaky
fe6043b 
Refs: #24305

PR-URL: #25197
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@Trott @BethGriggs
test: mark test-trace-events-api-worker-disabled flaky
f6b8469 
Refs: #24305

PR-URL: #25197
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@Trott @MylesBorins
test: mark test-trace-events-api-worker-disabled flaky
facf36e 
Refs: #24305

PR-URL: #25197
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the mark-worker-disabled-flaky branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @cjihrig @gireeshpunathil @BridgeAR